[Backport release-23.05] lib: modules.sh should check JSON output for predictability#275500
Closed
github-actions[bot] wants to merge 1 commit intorelease-23.05from
Closed
[Backport release-23.05] lib: modules.sh should check JSON output for predictability#275500github-actions[bot] wants to merge 1 commit intorelease-23.05from
modules.sh should check JSON output for predictability#275500github-actions[bot] wants to merge 1 commit intorelease-23.05from
Conversation
Currently, the `lib/tests/modules.sh` test checks the output of `nix-instantiate --eval` without `--json`, which outputs an unspecified human-readable format. This patch modifies `modules.sh` to use the `--json` output instead, to be robust against future changes to `nix-instantiate` output. (cherry picked from commit fa9727c)
github-actions
bot
requested review from
edolstra and
infinisil
as code owners
13 tasks
Member
|
Was already backported to staging, see #275264 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-23.05, triggered by a label in #275264.