lib: modules.sh should check JSON output for predictability#275264
lib: modules.sh should check JSON output for predictability#275264infinisil merged 1 commit intoNixOS:masterfrom
modules.sh should check JSON output for predictability#275264Conversation
github-actions
bot
added
6.topic: module system
ofborg
bot
added
10.rebuild-darwin: 0
Currently, the `lib/tests/modules.sh` test checks the output of `nix-instantiate --eval` without `--json`, which outputs an unspecified human-readable format. This patch modifies `modules.sh` to use the `--json` output instead, to be robust against future changes to `nix-instantiate` output.
9999years
force-pushed
the
lib-test-modules-json
branch
from
23e25e0 to
fa9727c
Compare
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin staging-23.05
git worktree add -d .worktree/backport-275264-to-staging-23.05 origin/staging-23.05
cd .worktree/backport-275264-to-staging-23.05
git switch --create backport-275264-to-staging-23.05
git cherry-pick -x fa9727cf1e4916d948529946b877eae7f0a61b0d |
1 similar comment
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin staging-23.05
git worktree add -d .worktree/backport-275264-to-staging-23.05 origin/staging-23.05
cd .worktree/backport-275264-to-staging-23.05
git switch --create backport-275264-to-staging-23.05
git cherry-pick -x fa9727cf1e4916d948529946b877eae7f0a61b0d |
|
Git push to origin failed for release-23.05 with exitcode 1 |
|
Successfully created backport PR for |
|
@9999years Oh, I only just realised that your manual backports in #275462 and #275268 went to the staging branches. This isn't ideal, they should go to the main development branches ( I'll close the automatic backports, those won't be necessary. If you're wondering about the staging workflow, see https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#staging |
2 participants
Description of changes
Currently, the
lib/tests/modules.shtest checks the output ofnix-instantiate --evalwithout--json, which outputs an unspecified human-readable format.This patch modifies
modules.shto use the--jsonoutput instead, to be robust against future changes tonix-instantiateoutput.See also: NixOS/nix#9606
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.