pcl: fix configurePhase with withCuda=true#275092
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
Hi, and thanks! The build probably broke because #271078 made cuda-related setup hooks more strict about when they're active, and it also had a regression addressed in #273048. Note that it's not evaluation that's broken, it's the configurePhase of the build (we'll want to update the commit message) |
SomeoneSerge
added
6.topic: cuda
|
Marking for backporting because 1) using |
al3xtjames
force-pushed
the
pcl-cudaPackages-update
branch
from
ed310d7 to
ce74ed5
Compare
NixOS#271078 caused the configurePhase of pcl to fail when withCuda is set to true. Fix NixOS#275090 by replacing cudatoolkit with cudaPackages.cuda_nvcc.
al3xtjames
force-pushed
the
pcl-cudaPackages-update
branch
from
ce74ed5 to
8db5a1a
Compare
al3xtjames
changed the title
|
Thanks for the suggestions. I've updated the PR (including the commit message). |
There was a problem hiding this comment.
❯ NIX_PATH= nix build --refresh -I nixpkgs=flake:github:al3xtjames/nixpkgs/pcl-cudaPackages-update -f '<nixpkgs>' --arg config '{ cudaSupport = true; cudaCapabilities = [ "8.6" ]; enableForwardCompat = false; allowUnfree = true; }' -L pcl --print-out-paths
/nix/store/wdrpmnri6inqlh615gzsc1jf6ldhf26y-pcl-1.13.0
LGTM. Waiting for ofborg an merging
delroth
added
the
12.approvals: 1
ofborg
bot
added
10.rebuild-darwin: 0
|
Successfully created backport PR for |
|
Thanks @al3xtjames! Unrelated to this PR, but we should probably mark the |
3 participants
Description of changes
#271078 caused the configurePhase of pcl to fail when
withCuda is set to true. Fix #275090 by replacing
cudatoolkit with cudaPackages.cuda_nvcc.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.