@AndersonTorres: seeing #308379 i assume this may be of interest to you. I'm running a nixpkgs review ATM

Yes, it is! Many thanks, I will take this into consideration.

Editing all-packages.nix brings a lot of merge conflicts, as always.

Result of nixpkgs-review pr 274836 -c commit run on x86_64-linux 1

i reran with -j1, and read through the non-empty failed logs that don't fail on hydra:

unrelated:

• _64gram: Hunk #1 failed
• bitwarden-desktop: _logHook: command not found
• collision: impure path /homeless-shelter/.cache/crystal/nix-store-dn5ck1qs500ywzd6wyyg4lmk042yy59c-crystal-1.11.2-lib-crystal-ecr-process.cr/macro_run used in link
• freefilesync: assertion failed: static_assert(CURL_LAST == CURLE_TOO_LARGE + 1);
• onboard: ModuleNotFoundError: No module named 'distutils'
• python311Packages.albumentations: albucore not installed

failed due to the nix-portable bwrap or /tmp being on a raid5:

• anki: test_create_open failed, assumes /attachroot.anki2 isn't writeable
• opustags: fail: opening a device as a partial file should fail

SDL related:

full logs

• hheretic:

  ./configure: line 5607: syntax error near unexpected token `SDL,'
  ./configure: line 5607: `    PKG_CHECK_MODULES(SDL, sdl >= $min_sdl_version,'
  

• hhexen:

  ./configure: line 5676: syntax error near unexpected token `SDL,'
  ./configure: line 5676: `    PKG_CHECK_MODULES(SDL, sdl >= $min_sdl_version,'
  
  

• powermanga:

  ./configure: line 5413: syntax error near unexpected token `SDL,'
  ./configure: line 5413: `    PKG_CHECK_MODULES(SDL, sdl >= $min_sdl_version,' 
  

Does it imply updates?
Or they will require keeping an older SDL around?

Does it imply updates? Or they will require keeping an older SDL around?

IMO it would be entirely fine to proceed as-is and defer fixing those 3 drvs to later PRs, assuming @pbsds' analysis is still up-to-date.

Longer term:

• hheretic/hhexen are under active maintenance, so I would expect upstream to either provide a fix for their buildsystem to be compatible with current versions of SDL, or at least merge one if we write it ;
• powermanga seems to be unmaintained since 2015, so I believe it would be more reasonable to make it as broken than keep an older version of SDL just for it; of course, that shouldn't stop anyone from writing a compatibility patch (which I'd guess would be similar to the fix for the other 2 drvs)

I'm currently too ill/tired to volunteer to fix those 3 drvs, though. :(

Addressed merge conflict, added updateScript, and updated (removing the last 3rd-party patch)

PS: Sorry for the noise, accidentally merged-in master instead of staging. That's now corrected (a second time, as I got meta.changelog wrong on the second merge)

I just dropped

d6e8960c1d71 powermanga: fix build
7d4f38ce7f11 tecnoballz: fix build
336d4418ff2e vp: fix build

As they don't seem to be needed anymore

:yeet:

Thanks for your work! I am a bit sorry to have killed your project of updating SDL1_classic, but this is probably for the better.

The situation was a bit different back in 2023, with SDL3 not yet on the horizon. I already noted in the OP back then however that fedora had replaced it with SDL_compat. In hindsight I should've started that migration instead 🙂