PR=274319; \
SYSTEM="aarch64-linux"; \
CUDA_SUPPORT="true"; \
CUDA_CAPABILITIES='[ "7.5" ]'; \
nixpkgs-review pr "$PR" \
  --system "$SYSTEM" \
  --no-shell \
  --checkout commit \
  --allow aliases \
  --build-args "--max-jobs 1" \
  --skip-package-regex 'python3(\d){1,2}Packages\.(pytorch-pfn-extras|ffcv)' \
  --skip-package-regex 'python3(\d){1,2}Packages\.(shap|mlflow|optuna)' \
  --extra-nixpkgs-config "{
    allowUnfree = true;
    allowBroken = false;
    cudaSupport = ${CUDA_SUPPORT:-false};
    cudaCapabilities = ${CUDA_CAPABILITIES:-[]};
  }"

PR=274319; \
RUN_NUMBER=13; \
SYSTEM="aarch64-linux"; \
CUDA_CAPABILITIES="7_5"; \
tar -cvf "$SYSTEM-cap-$CUDA_CAPABILITIES-pr-$PR-$RUN_NUMBER.tar.zst" \
  -I "zstd -T0 --ultra -22" \
  -C "$HOME/.cache/nixpkgs-review/pr-$PR-$RUN_NUMBER" \
  .

❌ aarch64-darwin

Result of nixpkgs-review pr 274319 --extra-nixpkgs-config '{ allowUnfree = true; allowBroken = false; cudaSupport = false; cudaCapabilities = [ ]; }' run on aarch64-darwin 1

❌ x86_64-darwin

Result of nixpkgs-review pr 274319 --extra-nixpkgs-config '{ allowUnfree = true; allowBroken = false; cudaSupport = false; cudaCapabilities = [ ]; }' run on x86_64-darwin 1

🕐 aarch64-linux

🕐 Jetson

🕐 Non-Jetson

🕐 Non-CUDA

🕐 x86_64-linux

🕐 Non-Jetson

🕐 Non-CUDA

My understanding is that meta.platform should list all of the platforms the package potentially could support, and that we prefer it to be static. It is also sufficient to set badPlatforms to affect meta.unsupported:

nix-repl> (runCommand "" { meta.badPlatforms = [builtins.currentSystem]; } "").meta.unsupported
true

I don't think we need to specify badPlatforms for source-provisioned packages, given that their dependencies' outPaths do not throw (well, except for the broken/unsupported errors). I didn't validate this however

My understanding is that meta.platform should list all of the platforms the package potentially could support, and that we prefer it to be static. It is also sufficient to set badPlatforms to affect meta.unsupported:

nix-repl> (runCommand "" { meta.badPlatforms = [builtins.currentSystem]; } "").meta.unsupported
true

I don't think we need to specify badPlatforms for source-provisioned packages, given that their dependencies' outPaths do not throw (well, except for the broken/unsupported errors). I didn't validate this however

Ah, yes I agree. I've switched to using brokenConditions for unrecognized or unsupported platforms (in the code this is the different between redistArch being null and src being set to null): https://github.com/NixOS/nixpkgs/blob/4c27877794122e7300f5cea588aa50c60c31b210/pkgs/development/cuda-modules/generic-builders/manifest.nix#L112-L117

getNixSystem has changed so it now returns aarch64-linux regardless of what we're targeting. Here's the old code:

And here's the new code:

https://github.com/NixOS/nixpkgs/blob/4c27877794122e7300f5cea588aa50c60c31b210/pkgs/development/cuda-modules/flags.nix#L145-L156

As a result, we can now see platforms for packages which aren't available on the current host (previously this would return the empty list when evaluated on x86_64-linux:

$ nix eval --impure .#cudaPackages.cuda_compat.meta.platforms
[ "aarch64-linux" ]

OfBorg, you're killing me. I'm running Nixpkgs-review on four different platforms with a total of seven different configurations and I'm not running into the eval error you are with Magma.

I suspect it's something to do with magma-cuda or magma-cuda-static, as those have cudaSupport forcibly set and that's the only reason OfBorg should be evaluating the build inputs gated by cudaSupport on unsupported platforms (like Darwin).

EDIT: Oh, right, OfBorg ignores meta.broken, so I need to set Darwin as a bad platform at the top level for the CUDA stuff.

EDIT2: Now it's failing while evaluating CUDA overrides: https://gist.github.com/GrahamcOfBorg/27410dc21a9025acf2a21363e2df48d2

I wonder if x.meta.unsupported (as well as badPlatforms = platforms) is wrong wrt splicing but I guess we can figure that out later?

❯ nix repl
Welcome to Nix 2.19.2. Type :? for help.
nix-repl> :l <nixpkgs>                                                         
Added 20031 variables.
nix-repl> pkgs = import <nixpkgs> { system = "x86_64-linux"; crossSystem = "aarch64-linux"; config.cudaCapabilities = [ "7.2" ]; }
nix-repl> lib.meta.availableOn pkgs.hostPlatform pkgs.cudaPackages.cuda_compat
true
nix-repl> lib.meta.availableOn pkgs.buildPlatform pkgs.cudaPackages.cuda_compat
false

How about that