Skip to content

Comments

Update test suite for Nix #9606 (23.05 backport)#274077

Closed
9999years wants to merge 1 commit intoNixOS:staging-23.05from
9999years:update-tests-for-nix-9606-staging-23.05
Closed

Update test suite for Nix #9606 (23.05 backport)#274077
9999years wants to merge 1 commit intoNixOS:staging-23.05from
9999years:update-tests-for-nix-9606-staging-23.05

Conversation

@9999years
Copy link
Contributor

Description of changes

#274069 backported to 23.05 because that's what Nix is currently based on.

NixOS/nix#9606 changes how values are printed in some cases. This updates the lib tests to work with the new output format, which should be familiar to nix repl users.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

NixOS/nix#9606 changes how values are printed in
some cases. This updates the lib tests to work with the new output
format, which should be familiar to `nix repl` users.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 14, 2023
@9999years 9999years closed this Dec 19, 2023
@9999years 9999years deleted the update-tests-for-nix-9606-staging-23.05 branch December 19, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant