postgresql: fix nixos tests and add xml support#27405
Merged
fpletz merged 3 commits intoNixOS:masterfrom Jul 20, 2017
Merged
Conversation
1. Needs to call makeTest or else nothing happens when you run `nix-build nixos/tests/postgresql.nix`. 2. Tests run as root, so there needs to be a corresponding user in PostgreSQL.
I suspect these functions aren't widely used, but they are enabled in PostgreSQL on Ubuntu and Arch.
|
@rvl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @paraseba, @basvandijk and @edolstra to be potential reviewers. |
fpletz
approved these changes
Jul 18, 2017
Contributor
|
Looks all good to me. Shall we go ahead and merge? |
Contributor
Author
|
OK thanks, I will just implement @volth's suggestion for -U postgres, then we can merge it.
|
Contributor
Author
|
Have updated the test now. |
fpletz
added
8.has: module (update)
Member
|
Thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Was looking at the XML functions, and thought it might be generally useful to enable them by default, as is done in Ubuntu and Arch.
Also noticed that the tests could not be invoked with
nix-build nixos/tests/postgresql.nix, so fixed that.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/) -- onlypostgresandpsql/cc @zagy @ocharles