Skip to content

libheif: 1.15.2 -> 1.17.6, python3Packages.pillow-heif: 0.14.0 -> 0.15.0#274003

Merged
mweinelt merged 2 commits intoNixOS:stagingfrom
999eagle:update/libheif
Feb 20, 2024
Merged

libheif: 1.15.2 -> 1.17.6, python3Packages.pillow-heif: 0.14.0 -> 0.15.0#274003
mweinelt merged 2 commits intoNixOS:stagingfrom
999eagle:update/libheif

Conversation

@999eagle
Copy link
Contributor

@999eagle 999eagle commented Dec 13, 2023

Description of changes

Supersedes #254708 and updates pillow-heif as well to make sure tests don't fail.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Dec 13, 2023
@999eagle 999eagle requested a review from ulrikstrid as a code owner December 14, 2023 09:24
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: steam Steam game store/launcher (store.steampowered.com) labels Dec 14, 2023
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: steam Steam game store/launcher (store.steampowered.com) labels Dec 14, 2023
@ofborg ofborg bot requested a review from gebner December 14, 2023 10:48
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Dec 14, 2023
@mweinelt
Copy link
Member

mweinelt commented Feb 17, 2024

Please rebase.

@999eagle 999eagle changed the title libheif: 1.15.2 -> 1.17.5, python3Packages.pillow-heif: 0.13.0 -> 0.14.0 libheif: 1.15.2 -> 1.17.6, python3Packages.pillow-heif: 0.14.0 -> 0.15.0 Feb 19, 2024
@999eagle
Copy link
Contributor Author

999eagle commented Feb 19, 2024

Rebased and updated

@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Feb 19, 2024
@ofborg ofborg bot removed 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Feb 19, 2024
@mweinelt
Copy link
Member

mweinelt commented Feb 19, 2024

@ofborg build python311Packages.pillow-heif

@mweinelt mweinelt merged commit 9f8f5da into NixOS:staging Feb 20, 2024
@vcunat
Copy link
Member

vcunat commented Mar 7, 2024 •
edited
Loading

The installed libheif-*.cmake files contain broken paths, which consequently breaks packages:

@vcunat vcunat mentioned this pull request Mar 7, 2024
Closed
1 task
vcunat added a commit that referenced this pull request Mar 7, 2024
@vcunat
libheif: fixup include path in .cmake file
5e0cda9 
/cc PR #274003 which introduced this issue.
@vcunat
Copy link
Member

vcunat commented Mar 7, 2024 •
edited
Loading

Patched in 5e0cda9
Feel free to improve further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhysmdnz rhysmdnz Awaiting requested review from rhysmdnz

@D4ndellion D4ndellion Awaiting requested review from D4ndellion

@FliegendeWurst FliegendeWurst Awaiting requested review from FliegendeWurst

@kashw2 kashw2 Awaiting requested review from kashw2

@ulrikstrid ulrikstrid Awaiting requested review from ulrikstrid

@gebner gebner Awaiting requested review from gebner

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@999eagle @mweinelt @vcunat @kashw2