cudaPackages: add missing newline to manifest builder#273873
Merged
ConnorBaker merged 1 commit intoNixOS:masterfrom Dec 13, 2023
Merged
Conversation
This was referenced Dec 13, 2023
Contributor
Author
|
Note Template PR=273873; \
SYSTEM="aarch64-linux"; \
CUDA_SUPPORT="true"; \
CUDA_CAPABILITIES='[ "7.5" ]'; \
nixpkgs-review pr "$PR" \
--system "$SYSTEM" \
--no-shell \
--checkout commit \
--allow aliases \
--build-args "--max-jobs 1" \
--extra-nixpkgs-config "{
allowUnfree = true;
allowBroken = false;
cudaSupport = ${CUDA_SUPPORT:-false};
cudaCapabilities = ${CUDA_CAPABILITIES:-[]};
}"✅
|
ofborg
bot
added
11.by: package-maintainer
ConnorBaker
force-pushed
the
fix/cudaPackages-installPhase-missing-newline
branch
from
6f7aa4b to
85bcd8c
Compare
SomeoneSerge
approved these changes
Dec 13, 2023
Contributor
There was a problem hiding this comment.
Maybe a more long-term solution would be to switch from script rendering to a static script that can read the JSON generated by __structuredAttrs. Then we'd be dealing with optionalAttrs and optionals instead of optionalString, and we'd have fewer conversions with strings as the bottlenecks
delroth
added
the
12.approvals: 1
SomeoneSerge
approved these changes
Dec 13, 2023
Contributor
SomeoneSerge
left a comment
SomeoneSerge
left a comment
There was a problem hiding this comment.
Silly Ofborg, I already said "yes"
aidalgol
approved these changes
Dec 13, 2023
delroth
added
12.approvals: 2
ConnorBaker
deleted the
fix/cudaPackages-installPhase-missing-newline
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #273321.
Bugfix is from #273321 (comment).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.