darwin/make-bootstrap-tools.nix: set -headerpad_max_install_names for…#273843
Merged
vcunat merged 1 commit intoNixOS:masterfrom Dec 13, 2023
Merged
darwin/make-bootstrap-tools.nix: set -headerpad_max_install_names for…#273843vcunat merged 1 commit intoNixOS:masterfrom
vcunat merged 1 commit intoNixOS:masterfrom
Conversation
ofborg
bot
added
6.topic: darwin
Member
|
Nit: built on x86_64-linux? I don't know what that means here. |
vcunat
approved these changes
Dec 13, 2023
Member
vcunat
left a comment
vcunat
left a comment
There was a problem hiding this comment.
Looks fine, and I confirm this fixing the build for x86_64-darwin.
Contributor
Author
Oh, should have been |
delroth
added
the
12.approvals: 1
shyim
approved these changes
Dec 13, 2023
Member
shyim
left a comment
shyim
left a comment
There was a problem hiding this comment.
Tested localy works fine aarch64
delroth
added
12.approvals: 2
… coreutils Without the change bootstrapTools build fails as: https://cache.nixos.org/log/g5wyq9xqshan6m3kl21bjn1z88hx48rh-stdenv-bootstrap-tools.drv error: install_name_tool: changing install names or rpaths can't be redone for: /nix/store/0hxg356h7lnl2hck23wrdpbib3cckx41-stdenv-bootstrap-tools/bin/tac (for architecture x86_64) because larger updated load commands do not fit (the program must be relinked, and you may need to use -headerpad or -headerpad_max_install_names)
trofi
force-pushed
the
darwin-coreutils
branch
from
a43bfb6 to
fccb480
Compare
Contributor
Author
|
Rebased against |
delroth
removed
the
12.approvals: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… coreutils
Without the change bootstrapTools build fails as:
https://cache.nixos.org/log/g5wyq9xqshan6m3kl21bjn1z88hx48rh-stdenv-bootstrap-tools.drv
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.