Skip to content

Comments

default jdk: 19 -> 21#273811

Merged
mweinelt merged 1 commit intoNixOS:masterfrom
jlesquembre:jdk21-default-stg
Mar 9, 2024
Merged

default jdk: 19 -> 21#273811
mweinelt merged 1 commit intoNixOS:masterfrom
jlesquembre:jdk21-default-stg

Conversation

@jlesquembre
Copy link
Member

@jlesquembre jlesquembre commented Dec 12, 2023

Description of changes

Update default JDK to 21.

JDK 21 is a LTS

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Dec 12, 2023
@jlesquembre jlesquembre changed the title default jdk: 19 -> 21 [staging] default jdk: 19 -> 21 Dec 13, 2023
l0b0
l0b0 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@l0b0 l0b0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JDK 21 release notes

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 18, 2023
@Tungsten842
Copy link
Member

Tungsten842 commented Jan 16, 2024

This would partially fix: #280901

@jlesquembre jlesquembre added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jan 16, 2024
@imincik imincik mentioned this pull request Jan 31, 2024
Merged
13 tasks
@mweinelt
Copy link
Member

mweinelt commented Feb 3, 2024

We can send this into master.

@mweinelt mweinelt requested a review from Infinidoge February 3, 2024 20:20
@mweinelt mweinelt marked this pull request as draft February 3, 2024 20:20
@wegank wegank mentioned this pull request Feb 3, 2024
Closed
Infinidoge
Infinidoge approved these changes Feb 4, 2024
View reviewed changes
Copy link
Contributor

@Infinidoge Infinidoge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're definitely late in the game for pushing this new version, but better late than never!

Hopefully shouldn't take too long to filter through staging.

@jlesquembre
Copy link
Member Author

jlesquembre commented Feb 4, 2024

Did I miss anything on the PR? Why was the PR set to draft?

@mweinelt
Copy link
Member

mweinelt commented Feb 4, 2024 •
edited
Loading

We can send this into master.

So you can rebase it to master, without pinging a lot of codeowners in the process.

@jlesquembre jlesquembre changed the base branch from staging to master February 4, 2024 11:12
@jlesquembre
Copy link
Member Author

jlesquembre commented Feb 4, 2024

@mweinelt thanks for clarifying it, I switched to master, let me know if there is anything else needed on my end

@Infinidoge Infinidoge mentioned this pull request Feb 4, 2024
Closed
13 tasks
@wegank wegank marked this pull request as ready for review February 4, 2024 12:22
@wegank wegank changed the title [staging] default jdk: 19 -> 21 default jdk: 19 -> 21 Feb 4, 2024
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Mar 8, 2024
@taku0
Copy link
Contributor

taku0 commented Mar 9, 2024

Can we merge this to master rather than staging? If mass-rebuilds is not a problem, I will merge this.

@Infinidoge
Copy link
Contributor

Infinidoge commented Mar 9, 2024

@mweinelt said that we could merge it into master. Pinging for confirmation.

@mweinelt mweinelt merged commit 775b2f0 into NixOS:master Mar 9, 2024
@locnide locnide mentioned this pull request Mar 11, 2024
Merged
13 tasks
@jlesquembre jlesquembre deleted the jdk21-default-stg branch March 12, 2024 09:44
@vcunat vcunat mentioned this pull request Mar 12, 2024
Merged
13 tasks
@vcunat
Copy link
Member

vcunat commented Mar 12, 2024

Note that various packages broke due to this update; this comparison should contain them (and some others that coincided): https://hydra.nixos.org/eval/1804895#tabs-now-fail

@newAM newAM mentioned this pull request Mar 18, 2024
Merged
13 tasks
@jlesquembre jlesquembre mentioned this pull request May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Infinidoge Infinidoge Infinidoge approved these changes

+1 more reviewer

@l0b0 l0b0 l0b0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@jlesquembre @Tungsten842 @mweinelt @taku0 @Infinidoge @vcunat @l0b0 @delroth @wegank