Skip to content

cudaPackages.autoAddCudaCompatRunpathHook: broken on jetsons#273781

Merged
yu-re-ka merged 2 commits intoNixOS:masterfrom
SomeoneSerge:feat/cuda-compat-fix-eval
Dec 12, 2023
Merged

cudaPackages.autoAddCudaCompatRunpathHook: broken on jetsons#273781
yu-re-ka merged 2 commits intoNixOS:masterfrom
SomeoneSerge:feat/cuda-compat-fix-eval

Conversation

@SomeoneSerge
Copy link
Contributor

@SomeoneSerge SomeoneSerge commented Dec 12, 2023

Prevent Ofborg evaluating cuda_compat in non-jetson variants of nixpkgs

Hopefully amends #267247 (comment)

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@SomeoneSerge SomeoneSerge force-pushed the feat/cuda-compat-fix-eval branch from ca5d4f4 to 445ab05 Compare December 12, 2023 16:21
@SomeoneSerge SomeoneSerge changed the title cudaPackages.setupCudaHook: mark broken on non-jetsons, to prevent th… cudaPackages.autoAddCudaCompatRunpathHook: broken on jetsons Dec 12, 2023
@yu-re-ka yu-re-ka merged commit 076fc3a into NixOS:master Dec 12, 2023
@ConnorBaker ConnorBaker added the 6.topic: cuda Parallel computing platform and API label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: cuda Parallel computing platform and API

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants