cudaPackages: prefix libPath with lib in manifest builder#273779
Merged
ConnorBaker merged 1 commit intoNixOS:masterfrom Dec 13, 2023
Merged
Conversation
13 tasks
Contributor
Author
|
Note Template PR=273779; \
SYSTEM="aarch64-linux"; \
CUDA_SUPPORT="true"; \
CUDA_CAPABILITIES='[ "7.5" ]'; \
nixpkgs-review pr "$PR" \
--system "$SYSTEM" \
--no-shell \
--checkout commit \
--allow aliases \
--build-args "--max-jobs 1" \
--extra-nixpkgs-config "{
allowUnfree = true;
allowBroken = false;
cudaSupport = ${CUDA_SUPPORT:-false};
cudaCapabilities = ${CUDA_CAPABILITIES:-[]};
}"
|
Member
|
Looks like something CUDA-related broke eval on master? |
Contributor
Author
|
@ofborg eval |
Contributor
|
This issue is in master. |
Contributor
Author
Do you know if |
Contributor
|
IIRC it does an eval of the base branch (master in this case), and an eval of the head branch (your branch). Either can fail the eval step |
ConnorBaker
force-pushed
the
fix/cudaPackages-libPath-manifest-builder
branch
from
dae8119 to
f13c797
Compare
ofborg
bot
added
11.by: package-maintainer
Contributor
|
I guess we're good ❯ nix build -I nixpkgs=flake:github:ConnorBaker/nixpkgs/fix/cudaPackages-libPath-manifest-builder -f '<nixpkgs>' --arg config '{ allowUnfree = true; }' cudaPackages.cutensor
❯ ls result/lib
libcutensorMg.so libcutensorMg.so.1 libcutensorMg.so.1.7.0 libcutensorMg_static.a libcutensor.so libcutensor.so.1 libcutensor.so.1.7.0 libcutensor_static.aBtw I only now noticed that |
| if [[ ! -d "${libPath}" ]] ; then | ||
| echo "${finalAttrs.pname}: ${libPath} does not exist, only found:" >&2 | ||
| find "$(dirname ${libPath})"/ -maxdepth 1 >&2 | ||
| full_lib_path="lib/${libPath}" |
Contributor
There was a problem hiding this comment.
I've also been wondering lately if it's better to pass this kind of values as environment variables instead of rendering them in the bash script, but that's not relevant rn I guess
SomeoneSerge
approved these changes
Dec 12, 2023
delroth
added
the
12.approvals: 1
Contributor
Author
Indeed it has :l |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #272797.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.