lib.fileset.gitTracked,gitTrackedWith: Minor improvements#273664
Merged
infinisil merged 2 commits intoNixOS:masterfrom Dec 13, 2023
Merged
lib.fileset.gitTracked,gitTrackedWith: Minor improvements#273664infinisil merged 2 commits intoNixOS:masterfrom
lib.fileset.gitTracked,gitTrackedWith: Minor improvements#273664infinisil merged 2 commits intoNixOS:masterfrom
Conversation
Introduce an internal function for them to share more behavior. This makes future changes easier.
ofborg
bot
added
10.rebuild-darwin: 0
1 task
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Just a refactoring and an improved error message for now.
This is motivated by a follow-up PR that should fix #269283 though :)
This work is sponsored by Antithesis ✨
Things done
Add a 👍 reaction to pull requests you find important.