Skip to content

xsimd: 11.2.0 -> 12.1.1#272992

Merged
marsam merged 1 commit intoNixOS:stagingfrom
trofi:xsimd-update
Dec 23, 2023
Merged

xsimd: 11.2.0 -> 12.1.1#272992
marsam merged 1 commit intoNixOS:stagingfrom
trofi:xsimd-update

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Dec 8, 2023 •
edited
Loading

Changes: xtensor-stack/xsimd@11.2.0...12.1.1

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from tobim December 9, 2023 03:18
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Dec 9, 2023
@misuzu
Copy link
Contributor

misuzu commented Dec 11, 2023

Could we please wait for the next version? xtensor-stack/xsimd#991 just got merged which fixes building issues on armv7l and riscv64

@trofi
Copy link
Contributor Author

trofi commented Dec 11, 2023

Could we please wait for the next version? xtensor-stack/xsimd#991 just got merged which fixes building issues on armv7l and riscv64

WDYT of applying that patch instead? (In case upstream takes some time to release). It looks simple. Applied the patch and pushed.

@misuzu
Copy link
Contributor

misuzu commented Dec 11, 2023

Could we please wait for the next version? xtensor-stack/xsimd#991 just got merged which fixes building issues on armv7l and riscv64

WDYT of applying that patch instead? (In case upstream takes some time to release). It looks simple. Applied the patch and pushed.

LGTM

misuzu
misuzu approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@misuzu misuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds on armv7l-linux and risc64-linux

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 11, 2023
@trofi trofi changed the title xsimd: 11.2.0 -> 12.1.0 xsimd: 11.2.0 -> 12.1.1 Dec 14, 2023
@trofi
Copy link
Contributor Author

trofi commented Dec 14, 2023

Updated to latest 12.1.1, dropped included backport.

@marsam marsam merged commit a6063c7 into NixOS:staging Dec 23, 2023
@trofi trofi deleted the xsimd-update branch December 23, 2023 13:39
@eliandoran eliandoran mentioned this pull request Dec 28, 2023
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@misuzu misuzu misuzu approved these changes

@tobim tobim Awaiting requested review from tobim

+1 more reviewer

@marsam marsam marsam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trofi @misuzu @marsam @delroth