Hey @IogaMaster I watched your video about NixOS and I would like to take you up on your offer of a PR review.

LGTM
I've encountered the same problem on one of my devices, and applying this patch fixes it.

Can this be merged, or is there a problem?

Needed to fix issue GoXLR-on-Linux/goxlr-utility/issues/138

Any plans to backport this to 23.11 once it's merged? This issue causes some audio interfaces that were working in 23.05 to not work properly in 23.11.

@errnoh I would love that. AFAIK from the CONTRIBUTING.md only a nixpkgs maintainer can backport. But what I'm wondering is why the "approved by: package-maintainer" label is not set, since I thought @roastiek was the maintainer of alsa-ucm-conf?
I think we have to wait for a nixpkgs committer anyway.

Hi @SuperSandro2000, can you please review this PR.

This PR will cause a whole lot of rebuilds because it's a dependency of alsa-lib, so maybe this should target staging and not master.

This should really be one comment otherwise LGTM

@SuperSandro2000 I squashed the commits. Hope it's good now.

please forgive my nix noob question. This fixes and issue I currently have with my goxlr. I was able to get this patch and apply it to the nixpkgs in my nix config but because so much depends on alsa it tried to rebuild like half the packages on my system from source. Is there any way for me to somehow apply to patch to the package but let all the other things on the system build with the old version? https://github.com/arh78750/nixosconfig/blob/d3d6f1ad90dfe5d626f9309a927cb93534af7a80/flake.nix#L19 here is where I'm applying the patch.

@arh78750 Since this is a very simple one-byte patch of a configuration file, I personally just manually edited the file of the broken package in the nix-store by temporarily mounting it rw. In practice you should never ever do that, but in this specific case it's an acceptable workaround because it doesn't affect dependent packages and would otherwise cause too many rebuilds. Just be prepared to redo it when you update your system.

You only need update settings of pipewire or pulseaudio service. Other applications don't read ucm configs directly.

You can change theirs package option with recompiled original againts patches alsa/alsa-ucm-conf.

Or setup ALSA_CONFIG_UCM2 env variable in those services to the new patched config. I think that it worked at leats with pulseaudio two years ago.

Does anyone know why "ofborg-eval" and "ofborg-eval-lib-tests" failed? I just squashed the two commits for @SuperSandro2000

Seems unrelated to me. Probably something else was broken on staging.

@ofborg build alsa-ucm-conf
@ofborg eval

@ofborg build alsa-ucm-conf
@ofborg eval

Hey @roastiek, can you review, pls.
Is there anything that needs to be taken care of or can it be merged?

@a-n-n-a-l-e-e thanks for the merge. Is it possible to backport this to 23.11?

Successfully created backport PR for staging-23.11:

• [Backport staging-23.11] alsa-ucm-conf: apply patch to fix SplitPCM: Device argument may not b… #283705