Skip to content

emacs: set 29 as default version and remove 28#272822

Closed
jian-lin wants to merge 0 commit intoNixOS:stagingfrom
linj-fork:pr/default-emacs-29-staging
Closed

emacs: set 29 as default version and remove 28#272822
jian-lin wants to merge 0 commit intoNixOS:stagingfrom
linj-fork:pr/default-emacs-29-staging

Conversation

@jian-lin
Copy link
Contributor

@jian-lin jian-lin commented Dec 8, 2023

Description of changes

Resubmit #270558 into the staging branch because of 25k rebuilds of all platforms.

Context:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jian-lin jian-lin requested a review from adisbladis as a code owner December 8, 2023 04:58
@github-actions github-actions bot added the 6.topic: emacs Text editor label Dec 8, 2023
@jian-lin jian-lin requested a review from ckiee December 8, 2023 04:58
@jian-lin jian-lin removed the request for review from ckiee December 8, 2023 05:12
@vcunat
Copy link
Member

vcunat commented Dec 8, 2023

I'm OK with keeping it in staging-next as a compromise (it comes earlier to master than staging). The last eval already contains the change due to getting merges from master. https://hydra.nixos.org/jobset/nixpkgs/staging-next

@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Dec 8, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Dec 8, 2023
@Atemu
Copy link
Member

Atemu commented Dec 8, 2023

@ckiee mentioned that doom-emacs still doesn't work with emacs29 for some reason. I'd prefer to hold off on dropping emacs28 until next release.

@jian-lin
Copy link
Contributor Author

jian-lin commented Dec 8, 2023

ckiee mentioned that doom-emacs still doesn't work with emacs29

To be clear, it is nix-doom-emacs, not doom emacs.

@AndersonTorres
Copy link
Member

As far as I remember the doom issue affects all Emacs, not merely the newer ones.

@ckiee
Copy link
Member

ckiee commented Dec 8, 2023

As far as I remember the [nix-doom-emacs] issue affects all Emacs, not merely the newer ones.

It builds on 28 and doesn't on 29. The last successful nixpkgs update was 3 months ago and since then it's been blocking on the E29 build failing. I plan to fix the underlying issues eventually but I've just been putting in the work here and there with no other takers for the most part.

@ckiee mentioned that doom-emacs still doesn't work with emacs29 for some reason. I'd prefer to hold off on dropping emacs28 until next release.

I'd appreciate it if we did

@jian-lin jian-lin marked this pull request as draft December 8, 2023 18:47
@jian-lin jian-lin closed this Dec 8, 2023
@jian-lin jian-lin force-pushed the pr/default-emacs-29-staging branch from 9fec722 to 7a7925e Compare December 8, 2023 20:07
@jian-lin
Copy link
Contributor Author

jian-lin commented Dec 8, 2023

Oops, this PR is automatically closed when I change the target branch from staging to staging-next according to the doc. So I create a new one #272984, which only bumps default Emacs version to 29 and does not remove 28. @vcunat Could you merge that one if it looks good to you?

@jian-lin jian-lin mentioned this pull request Dec 8, 2023
13 tasks
@jian-lin jian-lin deleted the pr/default-emacs-29-staging branch December 9, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: emacs Text editor 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants