Skip to content

mesa: use upstreamed patches for macOS fixes#272732

Merged
vcunat merged 1 commit intostagingfrom
pr/mesa_usptreamed_patches
Dec 9, 2023
Merged

mesa: use upstreamed patches for macOS fixes#272732
vcunat merged 1 commit intostagingfrom
pr/mesa_usptreamed_patches

Conversation

@veprbl
Copy link
Member

@veprbl veprbl commented Dec 7, 2023

There should be no functional difference, except using patches from main slightly reduces risk of the patches becoming unavailable for download.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

There should be no functional difference, except using patches from main
slightly reduces risk of the patches becoming unavailable for download.
@veprbl veprbl mentioned this pull request Dec 7, 2023
13 tasks
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 7, 2023
@veprbl
Copy link
Member Author

veprbl commented Dec 7, 2023

@GrahamcOfBorg eval

@ofborg ofborg bot requested review from primeos and vcunat December 8, 2023 02:43
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 8, 2023
@vcunat
Copy link
Member

vcunat commented Dec 8, 2023

If there's no functional difference, what about saving some rebuilds by targeting staging or staging-next?

@veprbl veprbl changed the base branch from master to staging December 8, 2023 17:29
@vcunat vcunat merged commit fc955d6 into staging Dec 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2023

Successfully created backport PR for staging-23.11:

@vcunat vcunat deleted the pr/mesa_usptreamed_patches branch December 9, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants