WIP: Python no runtime deps at build time#272179
Closed
adisbladis wants to merge 5 commits intoNixOS:masterfrom
Closed
WIP: Python no runtime deps at build time#272179adisbladis wants to merge 5 commits intoNixOS:masterfrom
adisbladis wants to merge 5 commits intoNixOS:masterfrom
Conversation
3 tasks
3 tasks
dcceee3 to
0050637
Compare
0050637 to
67d7d6b
Compare
196a0c1 to
6bb412c
Compare
6bb412c to
07a19f7
Compare
13 tasks
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Removes dependency propagation from
buildPythonPackagewhen a runtime dependency is passed viadependencies.Please don't actually review the code yet. This a a very WIP, very draft PoC & should be considered a demo for #272178.
This also includes the commits from #271597.
Only the commits prefixed with WIP: are a part of this.
python3Packages.fooDepending on a Python package like this will break:
You will instead need to:
This is because dependencies are no longer build-time propagated, so the full dependency graph calculation needs to happen in the Nix evaluator.
python3Packages.buildPythonPackagevspython3Packages.buildPythonApplicationbuildPythonPackageis for building a Python package without dependency propagationbuildPythonApplicationis for building application bundles. This internally callsbuildPythonPackage, and also creates a wrapper derivation that takes care of callingrequiredPythonModules.All Python applications which has runnable binaries now needs to either be:
buildPythonApplicationtoPythonApplicationThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.