nixos/archisteamfarm: don't use asf abbreviation for more clarity#272147
Merged
pbsds merged 2 commits intoNixOS:masterfrom Jan 22, 2024
Merged
nixos/archisteamfarm: don't use asf abbreviation for more clarity#272147pbsds merged 2 commits intoNixOS:masterfrom
pbsds merged 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: nixos
SuperSandro2000
force-pushed
the
archisteamfarm
branch
from
d9fde85 to
8d713c8
Compare
SuperSandro2000
force-pushed
the
archisteamfarm
branch
from
8d713c8 to
88f1771
Compare
pbsds
reviewed
Dec 28, 2023
SuperSandro2000
force-pushed
the
archisteamfarm
branch
from
b72d3f5 to
2e9ac71
Compare
Member
|
Reproduced the eval error locally with |
SuperSandro2000
force-pushed
the
archisteamfarm
branch
from
2e9ac71 to
244c052
Compare
Member
Author
|
A rebase seems to have fixed that. Not sure why but I take it. :) |
Member
|
Ofborg seems to disagree. Is it because the |
SuperSandro2000
force-pushed
the
archisteamfarm
branch
from
244c052 to
4f71420
Compare
ofborg
bot
added
10.rebuild-darwin: 0
MinerSebas
reviewed
Jan 8, 2024
SuperSandro2000
force-pushed
the
archisteamfarm
branch
2 times, most recently
from
09d4162 to
bd15168
Compare
MinerSebas
reviewed
Jan 9, 2024
Contributor
There was a problem hiding this comment.
Suggested change
| services.archisteamfarm.dataDir = lib.mkIf (lib.versionAtLeast config.system.stateVersion "24.05") "/var/lib/asf"; | |
| services.archisteamfarm.dataDir = mkIf (lib.versionAtLeast config.system.stateVersion "24.05") (mkDefault "/var/lib/asf"); |
Use mkDefault so that preexisting configs configs that override dataDir continue to function.
Also removed the lib. as the file already contains a with lib; at the top.
Member
Author
There was a problem hiding this comment.
Sure. Maybe I should drop that option entirely in another PR since I am not regularly testing it.
Also dropped with lib, since it is discouraged anyway.
SuperSandro2000
force-pushed
the
archisteamfarm
branch
from
bd15168 to
a15a9bb
Compare
SuperSandro2000
force-pushed
the
archisteamfarm
branch
from
a15a9bb to
6d1d912
Compare
pbsds
approved these changes
Jan 22, 2024
wolfgangwalther
added a commit
to wolfgangwalther/nixpkgs
that referenced
this pull request
Nov 22, 2024
Scheduled for 24.11. Added in NixOS#272147.
wolfgangwalther
added a commit
to wolfgangwalther/nixpkgs
that referenced
this pull request
Nov 24, 2024
Scheduled for 24.11. Added in NixOS#272147. (cherry picked from commit 4255d7a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.