This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3037

Please rebase away the merge commit.

Done.

might be worth pinging gifsik and wl-screenrec maintainers after merging so they know about the switch to ffmpeg_5 (it would be hard to notice the change in all-packages.nix)

Done.

there's a couple of comment typos but i'm not gonna nitpick comments

Can you point them? English is not my first language and I'm not fluent yet lol.

I think it's better to get more familiar with Nix and the Nixpkgs workflow before maintaining such an important package. I'll just do PRs for now.

Nah, you're fine. Maintainership "only" means that people come to you if the package needs to change. You'll get pinged on any PRs that touches ffmpeg for example.

What you need to maintain a package is knowledge about the package's specifics; how to test it still works etc. General Nix/Nixpkgs experience always helps of course but that's not the important part here.

I think it's better to get more familiar with Nix and the Nixpkgs workflow before maintaining such an important package. I'll just do PRs for now.

Nah, you're fine. Maintainership "only" means that people come to you if the package needs to change. You'll get pinged on any PRs that touches ffmpeg for example.

What you need to maintain a package is knowledge about the package's specifics; how to test it still works etc. General Nix/Nixpkgs experience always helps of course but that's not the important part here.

Oh thanks for the clarification, I think I'll add myself so.

@ofborg eval

Result of nixpkgs-review pr 271905 run on x86_64-linux 1

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1282

@Atemu @chayleaf @justinas and all the others that helped here. I just wanted to say thank you! I've been having only great experiences in this community. It's been 2 weeks since I started on NixOS and I'm already making a contribution this big! Have a great day you all!

Also, I think #260538 can be closed.

You're welcome @arthsmn :)

Not familiar with the stability of these packages across minor version bumps, but is this backportable to 23.11? punes on current 23.11 segfaults on startup:

Thread 1 ".punes-wrapped" received signal SIGSEGV, Segmentation fault.
0x00007ffff5a50147 in av_fifo_read () from /nix/store/dkxlgdrafqv3r91w8mfm06zvp7m24xj5-ffmpeg-6.0-lib/lib/libavutil.so.58
(gdb) bt
#0  0x00007ffff5a50147 in av_fifo_read () from /nix/store/dkxlgdrafqv3r91w8mfm06zvp7m24xj5-ffmpeg-6.0-lib/lib/libavutil.so.58
#1  0x00007ffff5cac3c2 in reorder_queue_flush () from /nix/store/dkxlgdrafqv3r91w8mfm06zvp7m24xj5-ffmpeg-6.0-lib/lib/libavcodec.so.60
#2  0x00007ffff5cae0d1 in ff_nvenc_encode_close () from /nix/store/dkxlgdrafqv3r91w8mfm06zvp7m24xj5-ffmpeg-6.0-lib/lib/libavcodec.so.60
#3  0x00007ffff5c7ecca in avcodec_close () from /nix/store/dkxlgdrafqv3r91w8mfm06zvp7m24xj5-ffmpeg-6.0-lib/lib/libavcodec.so.60
#4  0x00007ffff5c7ee34 in avcodec_open2[cold] () from /nix/store/dkxlgdrafqv3r91w8mfm06zvp7m24xj5-ffmpeg-6.0-lib/lib/libavcodec.so.60
#5  0x0000000000567176 in recording_init () at /build/source/src/core/recording.c:206
#6  0x0000000000454c3d in main (argc=<optimized out>, argv=0x7fffffffc978) at /build/source/src/core/main.c:95

Cherry-picking this merge onto nixos-23.11 fixes the crash locally.

Not familiar with the stability of these packages across minor version bumps, but is this backportable to 23.11? punes on current 23.11 segfaults on startup:

Thread 1 ".punes-wrapped" received signal SIGSEGV, Segmentation fault.
0x00007ffff5a50147 in av_fifo_read () from /nix/store/dkxlgdrafqv3r91w8mfm06zvp7m24xj5-ffmpeg-6.0-lib/lib/libavutil.so.58
(gdb) bt
#0  0x00007ffff5a50147 in av_fifo_read () from /nix/store/dkxlgdrafqv3r91w8mfm06zvp7m24xj5-ffmpeg-6.0-lib/lib/libavutil.so.58
#1  0x00007ffff5cac3c2 in reorder_queue_flush () from /nix/store/dkxlgdrafqv3r91w8mfm06zvp7m24xj5-ffmpeg-6.0-lib/lib/libavcodec.so.60
#2  0x00007ffff5cae0d1 in ff_nvenc_encode_close () from /nix/store/dkxlgdrafqv3r91w8mfm06zvp7m24xj5-ffmpeg-6.0-lib/lib/libavcodec.so.60
#3  0x00007ffff5c7ecca in avcodec_close () from /nix/store/dkxlgdrafqv3r91w8mfm06zvp7m24xj5-ffmpeg-6.0-lib/lib/libavcodec.so.60
#4  0x00007ffff5c7ee34 in avcodec_open2[cold] () from /nix/store/dkxlgdrafqv3r91w8mfm06zvp7m24xj5-ffmpeg-6.0-lib/lib/libavcodec.so.60
#5  0x0000000000567176 in recording_init () at /build/source/src/core/recording.c:206
#6  0x0000000000454c3d in main (argc=<optimized out>, argv=0x7fffffffc978) at /build/source/src/core/main.c:95

Cherry-picking this merge onto nixos-23.11 fixes the crash locally.

I think they don't bump versions on stable releases, maybe @Atemu can give a way.

This broke jellyfin-ffmpeg. It now fails with:

Unknown option "--enable-libaribcaption".

It can be fixed with

diff --git a/pkgs/development/libraries/jellyfin-ffmpeg/default.nix b/pkgs/development/libraries/jellyfin-ffmpeg/default.nix
index 7109a5d6dfd1..f519fb15b9b9 100644
--- a/pkgs/development/libraries/jellyfin-ffmpeg/default.nix
+++ b/pkgs/development/libraries/jellyfin-ffmpeg/default.nix
@@ -4,7 +4,7 @@
 , lib
 }:
 
-ffmpeg_6-full.overrideAttrs (old: rec {
+(ffmpeg_6-full.override { withAribcaption = false; }).overrideAttrs (old: rec {
   pname = "jellyfin-ffmpeg";
   version = "6.0.1-1";

But I have no idea if this is actually an acceptable fix. It looks like jellyfin-ffmpeg has not been updated with ffmpeg 6.1

This broke jellyfin-ffmpeg. It now fails with:

Unknown option "--enable-libaribcaption".

It can be fixed with

diff --git a/pkgs/development/libraries/jellyfin-ffmpeg/default.nix b/pkgs/development/libraries/jellyfin-ffmpeg/default.nix
index 7109a5d6dfd1..f519fb15b9b9 100644
--- a/pkgs/development/libraries/jellyfin-ffmpeg/default.nix
+++ b/pkgs/development/libraries/jellyfin-ffmpeg/default.nix
@@ -4,7 +4,7 @@
 , lib
 }:
 
-ffmpeg_6-full.overrideAttrs (old: rec {
+(ffmpeg_6-full.override { withAribcaption = false; }).overrideAttrs (old: rec {
   pname = "jellyfin-ffmpeg";
   version = "6.0.1-1";

But I have no idea if this is actually an acceptable fix. It looks like jellyfin-ffmpeg has not been updated with ffmpeg 6.1

First of all, jellyfin-ffmpeg will just be updated in version 7 of ffmpeg. This is a known issue and it's being discussed here and in the PRs associated with the issue.