Skip to content

buildPython*: use lib.extendDerivation' to fix overriding issues caused by lib.extendDerivation#271391

Draft
ShamrockLee wants to merge 4 commits intoNixOS:masterfrom
ShamrockLee:use-extend-derivation-fix-python
Draft

buildPython*: use lib.extendDerivation' to fix overriding issues caused by lib.extendDerivation#271391
ShamrockLee wants to merge 4 commits intoNixOS:masterfrom
ShamrockLee:use-extend-derivation-fix-python

Conversation

@ShamrockLee
Copy link
Contributor

Description of changes

Split from #269785
Depends on #269785, will be shorter once the dependent PR gets merged.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

ShamrockLee and others added 2 commits December 1, 2023 16:58
Add lib.extendDerivaton' as an overriding-aware alternative to
`lib.extendDerivation`.

Co-authored-by: Harsh Shandilya <[email protected]>
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes 6.topic: lib The Nixpkgs function library labels Dec 1, 2023
@ShamrockLee ShamrockLee force-pushed the use-extend-derivation-fix-python branch from 0325c2c to 9eea37e Compare December 1, 2023 09:34
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 1, 2023
@ShamrockLee ShamrockLee changed the title buildPythonPackages, buildPythonApplication: use lib.extendDerivation' to fix overriding issues caused by lib.extendDerivation buildPython*: use lib.extendDerivation' to fix overriding issues caused by lib.extendDerivation Dec 3, 2023
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: lib The Nixpkgs function library 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 8.has: changelog This PR adds or changes release notes 8.has: clean-up This PR removes packages or removes other cruft 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants