treewide: use lib.extendDerivation' instead of lib.extendDerivation where appropriate#271213
Draft
ShamrockLee wants to merge 4 commits intoNixOS:masterfrom
Draft
treewide: use lib.extendDerivation' instead of lib.extendDerivation where appropriate#271213ShamrockLee wants to merge 4 commits intoNixOS:masterfrom
lib.extendDerivation' instead of lib.extendDerivation where appropriate#271213ShamrockLee wants to merge 4 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: python
ShamrockLee
force-pushed
the
use-extend-derivation-fix
branch
from
545bef2 to
a0bbb89
Compare
github-actions
bot
removed
the
6.topic: python
ofborg
bot
added
the
2.status: merge conflict
Add lib.extendDerivaton' as an overriding-aware alternative to `lib.extendDerivation`. Co-authored-by: Harsh Shandilya <[email protected]>
Preserve the attributes update across overriding using
`lib.extendDerivaiton'`,
instead of plain `lib.extendDerivation`.
Take the Linux kernel package as an example:
```nix
pkgs.linuxPackages.kernel.features
=> { efiBootStub = true; ia32Emulation = true; iwlwifi = true; needsCifsUtils = true; netfilterRPFilter = true; }
\# Before
(pkgs.linuxPackages.kernel.overrideAttrs { }).features
=> error: attribute 'features' missing
\# After
(pkgs.linuxPackages.kernel.overrideAttrs { }).features
=> { efiBootStub = true; ia32Emulation = true; iwlwifi = true; needsCifsUtils = true; netfilterRPFilter = true; }
```
ShamrockLee
force-pushed
the
use-extend-derivation-fix
branch
from
a0bbb89 to
61526cd
Compare
13 tasks
ofborg
bot
added
10.rebuild-darwin: 0
ShamrockLee
changed the title
lib.extendDerivation' instead of lib.extendDerivaiton where appropriatelib.extendDerivation' instead of lib.extendDerivation where appropriate
wegank
added
the
2.status: merge conflict
wegank
added
the
2.status: stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix overriding issues caused by
lib.extendDerivationwithlib.extendDerivation'.lib.extendDerivaitonis designed for low-level usage and assume that there's no existing attributes that performs overriding (e.g.<pkgs>.overrideAttrs) in the derivation it updates.Split from #269785
Depends on #269785
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.