Skip to content

emacsPackages.emacspeak: 56.0 -> 58.0#270555

Merged
jian-lin merged 1 commit intoNixOS:masterfrom
linj-fork:pr/bump-emacspeak
Dec 7, 2023
Merged

emacsPackages.emacspeak: 56.0 -> 58.0#270555
jian-lin merged 1 commit intoNixOS:masterfrom
linj-fork:pr/bump-emacspeak

Conversation

@jian-lin
Copy link
Contributor

@jian-lin jian-lin commented Nov 28, 2023

This version is the newest one which builds1 with both Emacs 28 and
Emacs 29.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@jian-lin jian-lin requested a review from adisbladis as a code owner November 28, 2023 03:54
@github-actions github-actions bot added the 6.topic: emacs Text editor label Nov 28, 2023
@jian-lin
Copy link
Contributor Author

Could you help test this new version? @anpandey @matthew-piziak

@ofborg ofborg bot requested a review from AndersonTorres November 28, 2023 08:55
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 28, 2023
@AndersonTorres
Copy link
Member

Why the backport?

@jian-lin
Copy link
Contributor Author

Why the backport?

I think it is a good idea to backport #270558 and this PR is a soft dependency of that one.

This version is the newest one which builds[1] with both Emacs 28 and
Emacs 29.

[1]: tvraman/emacspeak@806c044
@github-actions github-actions bot added the 6.topic: emacs Text editor label Nov 29, 2023
@jian-lin jian-lin changed the title emacsPackages.emacspeak: 56.0 -> 59.0 emacsPackages.emacspeak: 56.0 -> 58.0 Nov 29, 2023
@jian-lin
Copy link
Contributor Author

Bump it to 58 to make CI happy. 58 is the newest version which builds fine with both Emacs 28 and Emacs 29.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1265

@jian-lin jian-lin merged commit 5271b9c into NixOS:master Dec 7, 2023
@jian-lin jian-lin deleted the pr/bump-emacspeak branch December 7, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: emacs Text editor 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants