emacsPackages.emacspeak: 56.0 -> 58.0#270555
Merged
jian-lin merged 1 commit intoNixOS:masterfrom Dec 7, 2023
Merged
Conversation
Contributor
Author
|
Could you help test this new version? @anpandey @matthew-piziak |
13 tasks
Member
|
Why the backport? |
Contributor
Author
I think it is a good idea to backport #270558 and this PR is a soft dependency of that one. |
This version is the newest one which builds[1] with both Emacs 28 and Emacs 29. [1]: tvraman/emacspeak@806c044
d6df9e6 to
564b868
Compare
Contributor
Author
|
Bump it to 58 to make CI happy. 58 is the newest version which builds fine with both Emacs 28 and Emacs 29. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version is the newest one which builds1 with both Emacs 28 and
Emacs 29.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.