python3.pkgs.pythonRuntimeDepsCheckHook: init by mweinelt · Pull Request #270457 · NixOS/nixpkgs

mweinelt · 2023-11-27T18:26:40Z

Description of changes

Implements a hook, that checks whether all dependencies, as specified by
the wheel manifest, are present in the current environment.

Complains about missing packages, as well as version specifier
mismatches.

Requires at least packaging>=23.2 and creates a bootstrap version of it.
Not sure if this is necessary, or if we should just not check on bootstrap packages.

Breaks the build for some packages, e.g., when we prevent infinite
recursion, like on sphinxcontrib packages, which have a dependency on sphinx.
What do we want to do here? Will set dontCheckRuntimeDeps for now.

Fixes: #250865

Things done

Priorities

Add a 👍 reaction to pull requests you find important.

mweinelt · 2023-11-28T15:31:07Z

Executing pythonRuntimeDepsCheck
Checking runtime dependencies for flask_sqlalchemy-3.1.1-py3-none-any.whl
  - sqlalchemy>=2.0.16 not satisifeid by version 2.0.21.dev0

Why is the version we pull from the tag 2.0.21.dev0? And why is that not greater than or equal 2.0.16?

    if package.version not in requirement.specifier:
        error(
            f"{package_name}{requirement.specifier} not satisifeid by version {package.version}"
        )
        return False

Not the whole truth. I delegate that to packaging.Requirement.

Solved in bdbeb01.

nixos-discourse · 2023-12-01T15:30:38Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/breaking-changes-announcement-for-unstable/17574/40

Diff: adamchainz/time-machine@2.12.0...2.13.0 Changelog: https://github.com/adamchainz/time-machine/blob/2.13.0/CHANGELOG.rst

Changelog: https://github.com/aio-libs/aiohttp/blob/v3.9.0/CHANGES.rst

Diff: aio-libs/aiohttp@refs/tags/v3.9.0...v3.9.1 Changelog: https://github.com/aio-libs/aiohttp/blob/v3.9.1/CHANGES.rst

https://github.com/encode/httpcore/blob/1.0.2/CHANGELOG.md

The badly maintained tests require nose3, which requires the imp module, which has been ripped out in 3.12.

https://github.com/encode/httpx/blob/refs/tags/0.25.2/CHANGELOG.md

Checking runtime dependencies for homeassistant-2023.11.3-py3-none-any.whl - httpx==0.25.0 not satisfied by version 0.25.2 - yarl==1.9.2 not satisifeid by version 1.9.3

They use nose, which relies on the imp module, which was been removed from Python 3.12.

https://github.com/python-babel/babel/blob/v2.13.1/CHANGES.rst

during check phase.

Upstream has no released version with Python 3.12 supported yet, but a patch was already merged, which works fine.

The `async_generator` module is a backport of async generators to Python 3.5 and it started failing on 3.12, but pulling it is safe.

mweinelt · 2023-12-02T03:27:53Z

Continues over in #271586.

github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 27, 2023

mweinelt requested review from FRidh, jonringer, natsukium and tjni November 27, 2023 18:26

mweinelt force-pushed the python-runtime-deps-check branch 4 times, most recently from a6ff14e to 30e73a2 Compare November 27, 2023 23:59

ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 8.has: package (new) This PR adds a new package labels Nov 28, 2023

ofborg bot requested a review from bennofs November 28, 2023 06:12

ofborg bot requested a review from fabaff November 28, 2023 06:50

mweinelt force-pushed the python-runtime-deps-check branch from 11c1327 to 562ad5c Compare November 28, 2023 16:31

ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Nov 28, 2023

mweinelt force-pushed the python-runtime-deps-check branch from 105d5d5 to 14e811e Compare November 29, 2023 00:29

mweinelt mentioned this pull request Nov 29, 2023

python3Packages.setuptools-scm: 7.1.0 -> 8.0.4 #270682

Merged

13 tasks

mweinelt force-pushed the python-runtime-deps-check branch from fb3650f to 146297f Compare November 29, 2023 17:01

natsukium mentioned this pull request Nov 30, 2023

python311Packages.typing-extensions: 4.7.1 -> 4.8.0 #267451

Closed

13 tasks

mweinelt mentioned this pull request Nov 30, 2023

mkdocs-material: 9.3.1 -> 9.4.14 #270796

Closed

13 tasks

caarlos0 approved these changes Nov 30, 2023

View reviewed changes

mweinelt mentioned this pull request Nov 30, 2023

python311Packages.aiohttp: 3.8.6 -> 3.9.1 #268935

Closed

13 tasks

github-actions bot added the 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab label Nov 30, 2023

mweinelt force-pushed the python-runtime-deps-check branch from 9e131c4 to c6ac6e8 Compare December 1, 2023 02:16

dotlambda and others added 21 commits December 1, 2023 17:58

python311Packages.time-machine: 2.12.0 -> 2.13.0

7619851

Diff: adamchainz/time-machine@2.12.0...2.13.0 Changelog: https://github.com/adamchainz/time-machine/blob/2.13.0/CHANGELOG.rst

python311Packages.aiohttp: 3.8.6 -> 3.9.0

ee0766b

Changelog: https://github.com/aio-libs/aiohttp/blob/v3.9.0/CHANGES.rst

python310Packages.aiohttp: unvendor llhttp

0296569

home-assistant: fetch aiohttp from GitHub

6e70d62

python311Packages.aiohttp: 3.9.0 -> 3.9.1

6d55f05

Diff: aio-libs/aiohttp@refs/tags/v3.9.0...v3.9.1 Changelog: https://github.com/aio-libs/aiohttp/blob/v3.9.1/CHANGES.rst

python311Packages.aioresponses: 0.7.4 -> 0.7.6

27dbdc8

python311Packages.httpcore: 0.18.0 -> 1.0.2

d9a801a

https://github.com/encode/httpcore/blob/1.0.2/CHANGELOG.md

python311Packages.idna: 3.4 -> 3.6

cfd186e

python311Packages.certifi: 2023.07.22 -> 2023.11.17

8a09a3a

python312Packages.eventlet: disable tests

5ce408a

The badly maintained tests require nose3, which requires the imp module, which has been ripped out in 3.12.

python311Packages.httpx: 0.25.0 -> 0.25.2

b1ae693

https://github.com/encode/httpx/blob/refs/tags/0.25.2/CHANGELOG.md

home-assistant: relax httpx, yarl constraints

2d8f709

Checking runtime dependencies for homeassistant-2023.11.3-py3-none-any.whl - httpx==0.25.0 not satisfied by version 0.25.2 - yarl==1.9.2 not satisifeid by version 1.9.3

python311Packages.apricot-select: move nose to check deps

7a7e2e0

python312Packages.pyrfc3339: disable tests

14aa779

They use nose, which relies on the imp module, which was been removed from Python 3.12.

python311Packages.babel: 2.12.1 -> 2.13.1

3f13d35

https://github.com/python-babel/babel/blob/v2.13.1/CHANGES.rst

python311Packages.itsdangerous: ignore deprecation warnings

041e484

during check phase.

python311Packages.testtools: 2.6.0 -> 2.7.1

5dfdbe9

python312Packages.curio: fix build

d5177bd

Upstream has no released version with Python 3.12 supported yet, but a patch was already merged, which works fine.

python312Packages.paginate: disable failing tests

f0fc852

python312Packages.pytest-trio: drop dependency on async-generator

a073ff6

The `async_generator` module is a backport of async generators to Python 3.5 and it started failing on 3.12, but pulling it is safe.

python312Packages.trio: drop dependency on async-generator

0cbd9ca

The `async_generator` module is a backport of async generators to Python 3.5 and it started failing on 3.12, but pulling it is safe.

mweinelt force-pushed the python-runtime-deps-check branch from c6ac6e8 to 0cbd9ca Compare December 1, 2023 16:59

This was referenced Dec 2, 2023

python311Packages.aioresponses: 0.7.4 -> 0.7.5 #267838

Closed

python311Packages.pytest-mock: 3.11.1 -> 3.12.0 #270345

Closed

[python-updates] 2023/12/02 major updates (python312Packages, pythonRuntimeDepsCheckHook) #271586

Merged

mweinelt closed this Dec 2, 2023

mweinelt deleted the python-runtime-deps-check branch December 2, 2023 03:28

mweinelt mentioned this pull request Dec 26, 2023

Restore python dependency validation #250865

Closed

genevieve-me mentioned this pull request Apr 5, 2024

Allow pre-/post-releases in pythonRuntimeDepsCheckHook #301698

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

python3.pkgs.pythonRuntimeDepsCheckHook: init #270457

python3.pkgs.pythonRuntimeDepsCheckHook: init #270457
mweinelt wants to merge 76 commits intoNixOS:masterfrom
mweinelt:python-runtime-deps-check

mweinelt commented Nov 27, 2023 •

edited

Loading

Uh oh!

mweinelt commented Nov 28, 2023 •

edited

Loading

Uh oh!

nixos-discourse commented Dec 1, 2023

Uh oh!

mweinelt commented Dec 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Comments

Conversation

mweinelt commented Nov 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Things done

Priorities

Uh oh!

mweinelt commented Nov 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nixos-discourse commented Dec 1, 2023

Uh oh!

mweinelt commented Dec 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mweinelt commented Nov 27, 2023 •

edited

Loading

mweinelt commented Nov 28, 2023 •

edited

Loading