Skip to content

nv-codec-headers-12: 12.0.16.0 -> 12.1.14.0; ffmpeg: 6.0 -> 6.1; jellyfin-ffmpeg: 6.0-7 -> 6.0.1-1#270429

Closed
arthsmn wants to merge 8 commits intoNixOS:stagingfrom
arthsmn:ffmpeg-update
Closed

nv-codec-headers-12: 12.0.16.0 -> 12.1.14.0; ffmpeg: 6.0 -> 6.1; jellyfin-ffmpeg: 6.0-7 -> 6.0.1-1#270429
arthsmn wants to merge 8 commits intoNixOS:stagingfrom
arthsmn:ffmpeg-update

Conversation

@arthsmn
Copy link
Member

@arthsmn arthsmn commented Nov 27, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@arthsmn arthsmn requested a review from Atemu November 27, 2023 14:41
@arthsmn
Copy link
Member Author

arthsmn commented Nov 27, 2023

@ofborg build jellyfin-ffmpeg

@arthsmn
Copy link
Member Author

arthsmn commented Nov 27, 2023

Why pipewire failed to build?

@arthsmn
Copy link
Member Author

arthsmn commented Nov 27, 2023

@ofborg build ffmpeg_6

@arthsmn
Copy link
Member Author

arthsmn commented Nov 27, 2023

@ofborg build jellyfin-ffmpeg

@arthsmn
Copy link
Member Author

arthsmn commented Nov 27, 2023

@ofborg build jellyfin-ffmpeg

@arthsmn
Copy link
Member Author

arthsmn commented Nov 27, 2023 •
edited
Loading

So, for some reason the x86_64-linux build isn't recognizing the hash that I set in the override.

@arthsmn
Copy link
Member Author

arthsmn commented Nov 27, 2023 •
edited
Loading

@Atemu I successfully built jellyfin-ffmpeg in my machine, a x86_64-linux one. The other builds are working as expected too. Ofborg's logs complain about the hash of the ffmpeg's override, but as you can see in the commit, it is there (that's why the other platforms and my local build build correctly).

@arthsmn
Copy link
Member Author

arthsmn commented Nov 27, 2023

@ofborg build jellyfin-ffmpeg

@Atemu Atemu self-assigned this Nov 27, 2023
@ofborg ofborg bot requested review from MP2E and justinas November 27, 2023 20:56
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Nov 27, 2023
justinas
justinas reviewed Nov 27, 2023
View reviewed changes
@justinas
Copy link
Member

justinas commented Nov 27, 2023

10000+ rebuilds estimated, you might need to target the staging branch.

@arthsmn arthsmn changed the base branch from master to staging November 27, 2023 22:00
Atemu
Atemu reviewed Nov 27, 2023
View reviewed changes
justinas
justinas reviewed Nov 27, 2023
View reviewed changes
@arthsmn
Copy link
Member Author

arthsmn commented Nov 27, 2023

@justinas @Atemu I'm deeply sorry. I was having problems with the jellyfin-ffmpeg and thought this was the issue, but I might have fixed the real issue in the process. Removed the unnecessary override.

@arthsmn
Copy link
Member Author

arthsmn commented Nov 27, 2023

@ofborg build jellyfin-ffmpeg

justinas
justinas approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@justinas justinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using 6ea3a51 I can build jellyfin-ffmpeg, Jellyfin transcodes.

I can not speak to any potential impact of changing nv-codec-headers-11 to nv-codec-headers-12 in general.

@arthsmn
Copy link
Member Author

arthsmn commented Nov 27, 2023

Using 6ea3a51 I can build jellyfin-ffmpeg, Jellyfin transcodes.

I can not speak to any potential impact of changing nv-codec-headers-11 to nv-codec-headers-12 in general.

This is needed, otherwise it won't build.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 27, 2023
@ofborg ofborg bot requested review from Atemu and justinas November 28, 2023 06:05
Atemu
Atemu reviewed Nov 28, 2023
View reviewed changes
@drupol drupol removed 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons. labels Dec 3, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Atemu Atemu Atemu requested changes

+3 more reviewers

@justinas justinas justinas approved these changes

@chayleaf chayleaf chayleaf approved these changes

@rhododendrox rhododendrox rhododendrox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Atemu Atemu

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@arthsmn @justinas @Atemu @rhododendrox @K900 @chayleaf @delroth @drupol @r-ryantm