libedit: manually define __STDC_ISO_10646__ to fix the build issue against musl#270143
Merged
emilytrau merged 1 commit intoNixOS:stagingfrom Dec 1, 2023
Merged
libedit: manually define __STDC_ISO_10646__ to fix the build issue against musl#270143emilytrau merged 1 commit intoNixOS:stagingfrom
emilytrau merged 1 commit intoNixOS:stagingfrom
Conversation
Contributor
|
Do you know why the build for |
Contributor
|
I think |
Contributor
|
|
…ainst musl Musl is ISO 10646 compliant but doesn't define __STDC_ISO_10646__ we need to do it ourselves.
635a8f1 to
cb202d1
Compare
trofi
approved these changes
Nov 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Musl is ISO 10646 compliant but doesn't define STDC_ISO_10646 we need to do it ourselves. Without this change, the following build will fail.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)I tested the following snippet with and without this patch: