Skip to content

nixos/tests/systemd-timesyncd: tmpfiles.rules -> tmpfiles.settings#270000

Merged
nikstur merged 1 commit intoNixOS:masterfrom
nikstur:fix-systemd-timesync-test
Nov 28, 2023
Merged

nixos/tests/systemd-timesyncd: tmpfiles.rules -> tmpfiles.settings#270000
nikstur merged 1 commit intoNixOS:masterfrom
nikstur:fix-systemd-timesync-test

Conversation

@nikstur
Copy link
Contributor

@nikstur nikstur commented Nov 25, 2023

This also fixes some warning systemd-tmpfiles was issuing before.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Nov 25, 2023
@nikstur
Copy link
Contributor Author

nikstur commented Nov 25, 2023

@ofborg test systemd-timesyncd

@nikstur nikstur requested a review from Lassulus November 25, 2023 22:11
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 26, 2023
This also fixes some warning systemd-tmpfiles was issuing before.
@nikstur nikstur force-pushed the fix-systemd-timesync-test branch from 8a1cc9d to 5257a52 Compare November 27, 2023 18:29
@nikstur nikstur requested a review from Lassulus November 27, 2023 18:29
@nikstur
Copy link
Contributor Author

nikstur commented Nov 27, 2023

@Lassulus all good now?

@nikstur nikstur merged commit 6a70cde into NixOS:master Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants