nixos/containers: warn if containers are used but disabled#269970
Merged
roberth merged 1 commit intoNixOS:masterfrom Nov 26, 2023
Merged
nixos/containers: warn if containers are used but disabled#269970roberth merged 1 commit intoNixOS:masterfrom
roberth merged 1 commit intoNixOS:masterfrom
Conversation
This is a follow-up to 8dfe8e4.
github-actions
bot
added
6.topic: nixos
13 tasks
Contributor
|
The diff is very large, did you accidentally format the file? |
Member
Author
I had to add a |
Contributor
No no all good, it just wasn't immediately obvious what has changed. |
delroth
added
the
12.approvals: 1
ofborg
bot
added
10.rebuild-darwin: 0
Member
|
Diff without whitespace changes: https://github.com/NixOS/nixpkgs/pull/269970/files?diff=split&w=1 |
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a follow-up to 8dfe8e4 (#263462).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)