Skip to content

[Backport staging-23.11] libgit2, http-parser: Fix Windows Build #269647

Merged
wegank merged 2 commits intostaging-23.11from
backport-269326-to-staging-23.11
Nov 30, 2023
Merged

[Backport staging-23.11] libgit2, http-parser: Fix Windows Build #269647
wegank merged 2 commits intostaging-23.11from
backport-269326-to-staging-23.11

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 24, 2023

Bot-based backport to staging-23.11, triggered by a label in #269326.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@Ericson2314 @github-actions
http-parser: Build on windows
861b757 
It actually does without modification, but what it installs isn't quite
right. This fixes that.

Specifying `uname` is in general more robust for cross, and specifying
those other variables always (when we just need to for Windows) helps
keep cross/native more similar for maintainability's sake.

The package is no longer maintained, so there isn't really anything to
upstream here.

(cherry picked from commit 966e7af)
@Ericson2314 @github-actions
libgit2: Fix build on Windows
908eafc 
(cherry picked from commit 2ba2808)
@github-actions github-actions bot mentioned this pull request Nov 24, 2023
Merged
13 tasks
@Ericson2314 Ericson2314 reopened this Nov 24, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Nov 24, 2023
@wegank wegank merged commit b269d99 into staging-23.11 Nov 30, 2023
@wegank wegank deleted the backport-269326-to-staging-23.11 branch November 30, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ericson2314 @wegank