Skip to content

libjxl: build gdk-pixbuf loader and thumbnailer#269570

Closed
zzzsyyy wants to merge 2 commits intoNixOS:stagingfrom
zzzsyyy:libjxl
Closed

libjxl: build gdk-pixbuf loader and thumbnailer#269570
zzzsyyy wants to merge 2 commits intoNixOS:stagingfrom
zzzsyyy:libjxl

Conversation

@zzzsyyy
Copy link
Member

@zzzsyyy zzzsyyy commented Nov 24, 2023 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@zzzsyyy zzzsyyy mentioned this pull request Nov 24, 2023
Merged
17 tasks
@ofborg ofborg bot requested a review from nh2 November 24, 2023 08:10
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Nov 24, 2023
@ofborg ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. and removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. labels Jan 18, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@amaxine amaxine mentioned this pull request Mar 29, 2024
Merged
27 tasks
@amaxine
Copy link
Contributor

amaxine commented Mar 29, 2024

@zzzsyyy could you rebase this and resolve the conflicts?

@zzzsyyy zzzsyyy mentioned this pull request Mar 29, 2024
Merged
13 tasks
@zzzsyyy
Copy link
Member Author

zzzsyyy commented Mar 29, 2024

Superseded by #299988

@zzzsyyy zzzsyyy closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nh2 nh2 Awaiting requested review from nh2

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zzzsyyy @amaxine @wegank