Skip to content

gnome/eog: add jxl support #269563

Merged
amaxine merged 2 commits intoNixOS:masterfrom
zzzsyyy:feat/jxl
Apr 19, 2024
Merged

gnome/eog: add jxl support #269563
amaxine merged 2 commits intoNixOS:masterfrom
zzzsyyy:feat/jxl

Conversation

@zzzsyyy
Copy link
Member

@zzzsyyy zzzsyyy commented Nov 24, 2023 •
edited
Loading

Description of changes

should after #299988

add jxl support for gnome and eog, closed #197005

Testing on gnome(wayland)

  • thumbnails in nautilus works
  • setting jxl wallpaper by settings works
  • setting jxl wallpaper by context menu works
  • opening jxl using eog works

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Nov 24, 2023
@zzzsyyy zzzsyyy changed the base branch from master to staging November 24, 2023 06:00
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab labels Nov 24, 2023
@zzzsyyy zzzsyyy changed the base branch from staging to master November 24, 2023 06:01
@github-actions github-actions bot removed 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab labels Nov 24, 2023
@zzzsyyy zzzsyyy force-pushed the feat/jxl branch 2 times, most recently from 545ca65 to f9df1c6 Compare November 24, 2023 06:09
@zzzsyyy zzzsyyy changed the title libjxl: enable plugins gnome/eog: add jxl support Nov 24, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Nov 24, 2023
@amaxine amaxine mentioned this pull request Mar 29, 2024
Merged
27 tasks
@zzzsyyy zzzsyyy changed the base branch from master to gnome-46 April 2, 2024 06:23
@zzzsyyy zzzsyyy changed the base branch from gnome-46 to master April 19, 2024 15:27
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 19, 2024
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: vim Advanced text editor 6.topic: module system About "NixOS" module system internals 6.topic: flakes The experimental Nix feature 6.topic: lib The Nixpkgs function library 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab and removed 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: vim Advanced text editor 6.topic: module system About "NixOS" module system internals 6.topic: flakes The experimental Nix feature 6.topic: lib The Nixpkgs function library 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab labels Apr 19, 2024
@zzzsyyy
Copy link
Member Author

zzzsyyy commented Apr 19, 2024

Due to this issue, some .jxl images are not are not thumbnailed correctly. upstream fixed this in libjxl/libjxl#3218 and here the update pr #288419 (Idk why it hasn't been backported)

Other things seem to work fine

@zzzsyyy zzzsyyy marked this pull request as ready for review April 19, 2024 16:02
@amaxine
Copy link
Contributor

amaxine commented Apr 19, 2024

I think we can accept fixes making it in a later staging cycle. Thanks for keeping track of this.

@amaxine amaxine merged commit 45a89f4 into NixOS:master Apr 19, 2024
@zzzsyyy zzzsyyy deleted the feat/jxl branch April 23, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dasj19 dasj19 Awaiting requested review from dasj19

@bobby285271 bobby285271 Awaiting requested review from bobby285271

@amaxine amaxine Awaiting requested review from amaxine

@jtojnar jtojnar Awaiting requested review from jtojnar

@hedning hedning Awaiting requested review from hedning

Assignees

No one assigned

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

eog: add libjxl for jpegxl support

2 participants

@zzzsyyy @amaxine