Result of nixpkgs-review pr 269415 run on x86_64-linux 1

Result of nixpkgs-review pr 269415 run on x86_64-linux 1
10 packages marked as broken and skipped:
148 packages failed to build:
82 packages built:

ffmpeg isn't building with this new version of libplacebo, this is what is causing all these failed builds. See https://trac.ffmpeg.org/ticket/10644.

While we wait for this ffmpeg issue to be resolved, we could update libplacebo only for mpv by creating a new package for the new version.
This way the other packages would still build without problems and we could update mpv to 0.37.0.

While we wait for this ffmpeg issue to be resolved, we could update libplacebo only for mpv by creating a new package for the new version. This way the other packages would still build without problems and we could update mpv to 0.37.0.

I was thinking this too. I was going to first try ffmpeg 6.1, which might have a fix, but I'm not having success building it, will try it again later.

So, I was able to successfully build ffmpeg 6.1 with libplacebo 6.338.1! All I did is make ffmpeg use nv-codec-headers-12 and apply this update. I think we should wait until the nv-codec-headers-12 update gets merged, update ffmpeg and then update libplacebo.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2979

Result of nixpkgs-review pr 269415 run on x86_64-linux 1

All failed builds should be a consequence of ffmpeg_6-full failing to build.
When the pr updating ffmpeg to 6.1 gets merged into master, I'll rebase my branch onto it.
After that everything should be fixed.

You could simply disable vf_libplacebo from ffmpeg for some time to fix build with ffmpeg 6.0(.1). Or patch it with this upstream commit (FFmpeg/FFmpeg@1231003). Here's a version of it rebased to apply on 6.0

I'm having some problems running nixpkgs-review.
For some reason it's downloading a lot of packages and I don't think I have enough space on disk to fit all of that.

What is missing for this PR? This is already preventing some updates.

I need someone to demonstrate to me that libplacebo still works in ffmpeg_6 with this because I don't know how I would.

I need someone to demonstrate to me that libplacebo still works in ffmpeg_6 with this because I don't know how I would.

You mean the 6.0?

As previously stated I've already confirmed that ffmpeg 6.1 works with libplacebo 6.338.1 by cherry picking some commits from the related pr.
But I understand that in order to be 100% sure I should build the package directly from this pr.
Since the last rebase this branch contains the commits updating ffmpeg to version 6.1 and because of that I already started building ffmpeg_6-full to see if it still works as I previously saw.
It will take some time as it's building a little bit more than 500 packages some of which are kinda big (e.g. llvm and clang).

It finally finished building and it works perfectly fine.
If anyone decides try to test this on their own be mindful you probably need to apply this commit (fc71dc9) before building, otherwise you'll get a error regarding the intel-media-sdk package and the whole build will fail.

When I merged this into staging-next, what command would I have to run in order to verify it still works?

I used this one:

ffmpeg -init_hw_device vulkan -i <input> \
-vf hwupload,libplacebo=w=1440:h=1440:upscaler=ewa_lanczos:downscaler=mitchell:format=yuv420p,hwdownload,format=yuv420p \
-c:v libx264 -c:a copy <output>

Missclicked

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1378

@ofborg build ffmpeg ffmpeg.passthru.tests ffmpeg-full
@ofborg build ffmpeg_5 ffmpeg_5.passthru.tests ffmpeg_5-full
@ofborg build libplacebo libplacebo.passthru.tests
@ofborg build libplacebo_5 libplacebo_5.passthru.tests
@ofborg build vlc vlc.passthru.tests

I'm not a fan of merging this with all the darwin failures here, but I don't personally run nix on darwin so I cannot look into it. That seems like a blocker to merging this, at least it's why I won't hit the button 🙂

Note that these failures are caused by this being based on staging and ofBorg needing to basically rebuild the world in a short amount of time. Its darwin machines are not capable of that.

Not sure why this was merged as-is since it breaks subsequent CI due to disregarding the pkgs/by-name policy: https://github.com/NixOS/nixpkgs/actions/runs/7600068348/job/20697863923?pr=282473

This PR's CI for by-name checks was green and the package in your error message is unrelated to this PR.