libgit2, http-parser: Fix Windows Build #269326
Merged
Ericson2314 merged 2 commits intoNixOS:stagingfrom Nov 24, 2023
Merged
Conversation
13 tasks
ofborg
bot
added
10.rebuild-darwin: 501+
Member
SuperSandro2000
left a comment
SuperSandro2000
left a comment
There was a problem hiding this comment.
otherwise fine for me
It actually does without modification, but what it installs isn't quite right. This fixes that. Specifying `uname` is in general more robust for cross, and specifying those other variables always (when we just need to for Windows) helps keep cross/native more similar for maintainability's sake. The package is no longer maintained, so there isn't really anything to upstream here.
Ericson2314
force-pushed
the
libgit-windows
branch
from
9fe896a to
2ba2808
Compare
SuperSandro2000
approved these changes
Nov 24, 2023
Member
Author
|
I think this is a spurious failure because staging? At least it looks like a timeout and the backport I already made (to try out, and because conflicts will prevent the automatic one from working) passed CI fine. |
Member
Author
|
In fact, the packages I changed don't appear in the log; it's definitely spurious. |
1 task
Contributor
|
Successfully created backport PR for |
Member
|
Yeah, otherwise we fix it along staging-next. Shouldn't be to hard I hope. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.