python3Packages.numpy: fix cross compilation#268587
Merged
mweinelt merged 2 commits intoNixOS:stagingfrom Nov 24, 2023
Merged
Conversation
The full path of the build Python intepreter gets stored in numpy/__config__.py and thus the built wheel. Leaving the reference is annoying for regular builds but fatal for cross builds.
Add mesonEmulatorHook, along with a small hack to make it function properly with meson-python.
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
the
6.topic: cross-compilation
ofborg
bot
added
10.rebuild-darwin: 501+
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes cross-compilation that was broken by the recent change to Meson. The fix is kind of a hack, but it works.
meson-pythonand/ormesonEmulatorHookprobably need to be modified to agree better. See also #260637 (comment)Cross-compiled numpy on master from
x86_64-linuxtoarmv7l-linuxand it seems to work fine. I ran a bit of the test suite successfully (not patient enough for the whole thing) and was able to generally do numpy stuff without it exploding and dying. I also checked that a native compilation forx86_64-linuxstill works.cc @amjoseph-nixpkgs
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)