Skip to content

Comments

lib.fileset: Minor changes#268520

Merged
infinisil merged 1 commit intoNixOS:masterfrom
tweag:fileset-minor-changes
Nov 19, 2023
Merged

lib.fileset: Minor changes#268520
infinisil merged 1 commit intoNixOS:masterfrom
tweag:fileset-minor-changes

Conversation

@infinisil
Copy link
Member

@infinisil infinisil commented Nov 19, 2023

Description of changes

Originally part of #267091, but should be done on its own:

  • Make fromSource's missing file error message more consistent with others, and add a test for it
  • Indent some function arguments
  • Fix an internal type

This work is sponsored by Antithesis

Things done

  • Ran the tests

- Make fromSource's missing file error message more consistent with others,
  and add a test for it
- Indent some function arguments
- Fix an internal type
@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label Nov 19, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 19, 2023
@infinisil infinisil merged commit 5a7118d into NixOS:master Nov 19, 2023
@infinisil infinisil deleted the fileset-minor-changes branch November 19, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: lib The Nixpkgs function library 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant