Skip to content

geos: 3.11.2 -> 3.12.1#268130

Merged
zimbatm merged 8 commits intoNixOS:masterfrom
imincik:geos-3.12.1
Dec 14, 2023
Merged

geos: 3.11.2 -> 3.12.1#268130
zimbatm merged 8 commits intoNixOS:masterfrom
imincik:geos-3.12.1

Conversation

@imincik
Copy link
Contributor

@imincik imincik commented Nov 17, 2023 •
edited
Loading

Description of changes

Update GEOS to the latest version.

List of changes:

This PR was successfully tested with current Shapely version (2.0.2).

This PR also contains following changes:

  • keep GEOS 3.11.2 as geos_3_11 (required for pygeos and kikit)
  • keep shapely 1.8.5 as shapely_1_8 (required for kikit)
  • update pygeos and kikit to use geos_3_11 and shapely_1_8
  • rename geos39 to geos_3_9

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@imincik imincik mentioned this pull request Nov 17, 2023
Closed
12 tasks
@imincik
Copy link
Contributor Author

imincik commented Nov 17, 2023

@ofborg build geos python3Packages.shapely

@ofborg ofborg bot requested review from nh2, sikmir and willcohen November 17, 2023 18:11
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Nov 17, 2023
@imincik imincik mentioned this pull request Nov 22, 2023
Closed
13 tasks
@imincik
Copy link
Contributor Author

imincik commented Dec 5, 2023

I am running nixpkgs-review now ...

@ofborg ofborg bot requested review from das-g and nialov December 5, 2023 13:21
@imincik
Copy link
Contributor Author

imincik commented Dec 5, 2023

nixpkgs-review is still running ... Building tensorflow.

@imincik
Copy link
Contributor Author

imincik commented Dec 6, 2023 •
edited
Loading

After many hours, nixpkgs-review crashed. I am not sure why.

From logs, I see following packages having problems with GEOS 3.12.1:

       last 10 log lines:
       > FAILED pygeos/tests/test_set_operations.py::test_coverage_union_non_polygon_inputs[geom_134-geom_234] - Failed: DID NOT RAISE <class 'pygeos.GEOSException'>
       > FAILED pygeos/tests/test_set_operations.py::test_coverage_union_non_polygon_inputs[geom_135-geom_235] - AssertionError: Regex pattern did not match.
       > FAILED pygeos/tests/test_set_operations.py::test_coverage_union_non_polygon_inputs[geom_136-geom_236] - AssertionError: Regex pattern did not match.
       > FAILED pygeos/tests/test_set_operations.py::test_coverage_union_non_polygon_inputs[geom_137-geom_237] - AssertionError: Regex pattern did not match.
       > FAILED pygeos/tests/test_set_operations.py::test_coverage_union_non_polygon_inputs[geom_138-geom_238] - AssertionError: Regex pattern did not match.
       > FAILED pygeos/tests/test_set_operations.py::test_coverage_union_non_polygon_inputs[geom_139-geom_239] - AssertionError: Regex pattern did not match.
       > FAILED pygeos/tests/test_set_operations.py::test_coverage_union_non_polygon_inputs[geom_140-geom_240] - AssertionError: Regex pattern did not match.
       > FAILED pygeos/tests/test_set_operations.py::test_coverage_union_non_polygon_inputs[geom_141-geom_241] - AssertionError: Regex pattern did not match.
  • psycopg
       last 10 log lines:
       >
       > >       assert n[0] == n[1] == n[2], f"objects leaked: {n[1] - n[0]}, {n[2] - n[1]}"
       > E       AssertionError: objects leaked: -1, 1
       > E       assert 222934 == 222933
       >
       > tests/test_copy_async.py:790: AssertionError
       > =========================== short test summary info ============================
       > FAILED tests/test_copy_async.py::test_copy_from_leaks[asyncio-Format.TEXT-False] - AssertionError: objects leaked: -1, 1

       last 10 log lines:
       > FAILED tests/test_create_inconsistent_dimensionality.py::test_create_from_wkt[MULTIPOINT (1 1 1, 2 2)-MULTIPOINT Z (1 1 1, 2 2 0)] - shapely.errors.WKTReadingError: Could not create geometry because of errors...
       > FAILED tests/test_create_inconsistent_dimensionality.py::test_create_from_wkt[MULTIPOINT (1 1, 2 2 2)-MULTIPOINT Z (1 1 0, 2 2 2)] - shapely.errors.WKTReadingError: Could not create geometry because of errors...
       > FAILED tests/test_create_inconsistent_dimensionality.py::test_create_from_wkt[LINESTRING (1 1 1, 2 2)-LINESTRING Z (1 1 1, 2 2 0)] - shapely.errors.WKTReadingError: Could not create geometry because of errors...
       > FAILED tests/test_create_inconsistent_dimensionality.py::test_create_from_wkt[POLYGON ((0 0 0, 1 0 0, 1 1, 0 1 0, 0 0 0))-POLYGON Z ((0 0 0, 1 0 0, 1 1 0, 0 1 0, 0 0 0))] - shapely.errors.WKTReadingError: Could not create geometry
because of errors...
       > FAILED tests/test_create_inconsistent_dimensionality.py::test_create_from_wkt[LINESTRING (1 1, 2 2 2)-LINESTRING (1 1, 2 2)] - shapely.errors.WKTReadingError: Could not create geometry because of errors...
       > FAILED tests/test_create_inconsistent_dimensionality.py::test_create_from_wkt[POLYGON ((0 0, 1 0 1, 1 1, 0 1, 0 0))-POLYGON ((0 0, 1 0, 1 1, 0 1, 0 0))] - shapely.errors.WKTReadingError: Could not create geometry because of errors.
..
       > FAILED tests/test_parallel_offset.py::OperationsTestCase::test_parallel_offset_linestring - AssertionError: <shapely.geometry.linestring.LineString object at 0x7fff729...
       > FAILED tests/test_voronoi_diagram.py::test_edges - assert False

@nialov
Copy link
Contributor

nialov commented Dec 6, 2023

Error in psycopg is related to flaky tests, they sometimes fail, sometimes not. Fix in progress: psycopg/psycopg#693 & #271926

@nialov
Copy link
Contributor

nialov commented Dec 6, 2023

I will take a look at pygeos

@nialov
Copy link
Contributor

nialov commented Dec 6, 2023 •
edited
Loading

Errors in pygeos are mostly related to this change in the changelog of geos:

  - CoverageUnion now requires valid inputs to produce valid outputs
    and may return invalid outputs silently when fed invalid inputs.

pygeos expects in the tests that invalid inputs result in an exception. After the change invalid outputs are given rather than an exception is raised.

But there are other errors as well:

       > FAILED pygeos/tests/test_constructive.py::test_oriented_envelope[geometry0-expected0] - assert False
       > FAILED pygeos/tests/test_constructive.py::test_oriented_envelope[geometry2-expected2] - assert False
       > FAILED pygeos/tests/test_constructive.py::test_minimum_rotated_rectangle[geometry0-expected0] - assert False
       > FAILED pygeos/tests/test_constructive.py::test_minimum_rotated_rectangle[geometry2-expected2] - assert False
       > FAILED pygeos/tests/test_io.py::test_to_wkt_multipoint_with_point_empty - AssertionError: assert 'MULTIPOINT (EMPTY, (2 3))' == 'MULTIPOINT (EMPTY, 2...

which are starting to look like ones that are not worth patching in nixpkgs. And a pull request to pygeos is not a good option as upstream has continued development in shapely and pygeos is nearing archive status.

I am wondering if this is the point at which either

  1. pygeosis deprecated
  2. The offending tests are just skipped with skipif and GEOS version condition

Feedback appreciated...

Rough patch for pygeos without actually determining why some tests fail is here: pygeos/pygeos@master...nialov:pygeos:fix-tests-for-geos-3.12.1

@imincik
Copy link
Contributor Author

imincik commented Dec 6, 2023 •
edited
Loading 

nixpkgs-review pr --build-args "--max-jobs 2 --cores 8" --post-result --skip-package-regex '.*rlax.*' 268130

Result of nixpkgs-review pr 268130 run on x86_64-linux 1

11 packages marked as broken and skipped:
  • python310Packages.paddleocr
  • python310Packages.paddleocr.dist
  • python310Packages.unstructured-inference
  • python310Packages.unstructured-inference.dist
  • python310Packages.worldengine
  • python310Packages.worldengine.dist
  • python311Packages.worldengine
  • python311Packages.worldengine.dist
  • t-rex
  • worldengine-cli
  • worldengine-cli.dist
20 packages failed to build:
  • kicadAddons.kikit
  • kicadAddons.kikit-library
  • kikit
  • kikit.dist
  • python310Packages.bsuite
  • python310Packages.bsuite.dist
  • python310Packages.opensfm
  • python310Packages.opensfm.dist
  • python310Packages.plotnine
  • python310Packages.plotnine.dist
  • python310Packages.pygeos
  • python310Packages.pygeos.dist
  • python311Packages.bsuite
  • python311Packages.bsuite.dist
  • python311Packages.opensfm
  • python311Packages.opensfm.dist
  • python311Packages.plotnine
  • python311Packages.plotnine.dist
  • python311Packages.pygeos
  • python311Packages.pygeos.dist
216 packages built:
  • apacheHttpdPackages.mod_tile (apacheHttpdPackages_2_4.mod_tile)
  • cloudcompare
  • cura
  • easyocr (python311Packages.easyocr)
  • easyocr.dist (python311Packages.easyocr.dist)
  • entwine
  • gdal (python311Packages.gdal)
  • gdalMinimal
  • geos
  • gmt
  • gplates
  • grass
  • haskellPackages.hgdal
  • haskellPackages.hgdal.doc
  • haskellPackages.hgeos
  • haskellPackages.hgeos.data
  • haskellPackages.hgeos.doc
  • librasterlite2
  • librttopo
  • librttopo.dev
  • libspatialite
  • libspatialite.dev
  • mapcache
  • mapnik
  • mapproxy
  • mapproxy.dist
  • mapserver
  • merkaartor
  • moonraker
  • mysql-workbench
  • octavePackages.mapping
  • openorienteering-mapper
  • osm2pgsql
  • osmscout-server
  • paraview
  • pdal
  • perl536Packages.Tirex
  • perl536Packages.Tirex.devdoc
  • perl538Packages.Tirex
  • perl538Packages.Tirex.devdoc
  • pgadmin4
  • pgadmin4-desktopmode
  • pgadmin4-desktopmode.dist
  • pgadmin4.dist
  • pgcli (python311Packages.pgcli)
  • pgcli.dist (python311Packages.pgcli.dist)
  • postgresql12JitPackages.postgis
  • postgresql12JitPackages.postgis.doc
  • postgresql12Packages.postgis
  • postgresql12Packages.postgis.doc
  • postgresql13JitPackages.postgis
  • postgresql13JitPackages.postgis.doc
  • postgresql13Packages.postgis
  • postgresql13Packages.postgis.doc
  • postgresql14JitPackages.postgis
  • postgresql14JitPackages.postgis.doc
  • postgresql14Packages.postgis
  • postgresql14Packages.postgis.doc
  • postgresqlJitPackages.postgis (postgresql15JitPackages.postgis)
  • postgresqlJitPackages.postgis.doc (postgresql15JitPackages.postgis.doc)
  • postgresqlPackages.postgis (postgresql15Packages.postgis)
  • postgresqlPackages.postgis.doc (postgresql15Packages.postgis.doc)
  • postgresql16JitPackages.postgis
  • postgresql16JitPackages.postgis.doc
  • postgresql16Packages.postgis
  • postgresql16Packages.postgis.doc
  • python310Packages.aplpy
  • python310Packages.aplpy.dist
  • python310Packages.asf-search
  • python310Packages.asf-search.dist
  • python310Packages.basemap
  • python310Packages.basemap.dist
  • python310Packages.cartopy
  • python310Packages.cartopy.dist
  • python310Packages.cf-xarray
  • python310Packages.cf-xarray.dist
  • python310Packages.django-bootstrap4
  • python310Packages.django-bootstrap4.dist
  • python310Packages.easyocr
  • python310Packages.easyocr.dist
  • python310Packages.fiona
  • python310Packages.fiona.dist
  • python310Packages.flask-admin
  • python310Packages.flask-admin.dist
  • python310Packages.folium
  • python310Packages.folium.dist
  • python310Packages.gdal
  • python310Packages.geoalchemy2
  • python310Packages.geoalchemy2.dist
  • python310Packages.geopandas
  • python310Packages.geopandas.dist
  • python310Packages.glueviz
  • python310Packages.glueviz.dist
  • python310Packages.labelbox
  • python310Packages.labelbox.dist
  • python310Packages.osmnx
  • python310Packages.osmnx.dist
  • python310Packages.owslib
  • python310Packages.owslib.dist
  • python310Packages.pgcli
  • python310Packages.pgcli.dist
  • python310Packages.pgspecial
  • python310Packages.pgspecial.dist
  • python310Packages.pgvector
  • python310Packages.pgvector.dist
  • python310Packages.preprocess-cancellation
  • python310Packages.preprocess-cancellation.dist
  • python310Packages.psycopg
  • python310Packages.psycopg.dist
  • python310Packages.psycopg.doc
  • python310Packages.pvextractor
  • python310Packages.pvextractor.dist
  • python310Packages.pygmt
  • python310Packages.pygmt.dist
  • python310Packages.pyosmium
  • python310Packages.pyosmium.dist
  • python310Packages.pyproj
  • python310Packages.pyproj.dist
  • python310Packages.pytest-postgresql
  • python310Packages.pytest-postgresql.dist
  • python310Packages.python-mapnik
  • python310Packages.python-mapnik.dist
  • python310Packages.qcodes
  • python310Packages.qcodes-contrib-drivers
  • python310Packages.qcodes-contrib-drivers.dist
  • python310Packages.qcodes.dist
  • python310Packages.rasterio
  • python310Packages.rasterio.dist
  • python310Packages.shapely
  • python310Packages.shapely.dist
  • python310Packages.spectral-cube
  • python310Packages.spectral-cube.dist
  • python310Packages.uranium
  • python310Packages.wktutils
  • python310Packages.wktutils.dist
  • python310Packages.wrf-python
  • python310Packages.wrf-python.dist
  • python311Packages.aplpy
  • python311Packages.aplpy.dist
  • python311Packages.asf-search
  • python311Packages.asf-search.dist
  • python311Packages.basemap
  • python311Packages.basemap.dist
  • python311Packages.cartopy
  • python311Packages.cartopy.dist
  • python311Packages.cf-xarray
  • python311Packages.cf-xarray.dist
  • python311Packages.django-bootstrap4
  • python311Packages.django-bootstrap4.dist
  • python311Packages.fiona
  • python311Packages.fiona.dist
  • python311Packages.flask-admin
  • python311Packages.flask-admin.dist
  • python311Packages.folium
  • python311Packages.folium.dist
  • python311Packages.geoalchemy2
  • python311Packages.geoalchemy2.dist
  • python311Packages.geopandas
  • python311Packages.geopandas.dist
  • python311Packages.glueviz
  • python311Packages.glueviz.dist
  • python311Packages.labelbox
  • python311Packages.labelbox.dist
  • python311Packages.osmnx
  • python311Packages.osmnx.dist
  • python311Packages.owslib
  • python311Packages.owslib.dist
  • python311Packages.pgspecial
  • python311Packages.pgspecial.dist
  • python311Packages.pgvector
  • python311Packages.pgvector.dist
  • python311Packages.preprocess-cancellation
  • python311Packages.preprocess-cancellation.dist
  • python311Packages.psycopg
  • python311Packages.psycopg.dist
  • python311Packages.psycopg.doc
  • python311Packages.pvextractor
  • python311Packages.pvextractor.dist
  • python311Packages.pygmt
  • python311Packages.pygmt.dist
  • python311Packages.pyosmium
  • python311Packages.pyosmium.dist
  • python311Packages.pyproj
  • python311Packages.pyproj.dist
  • python311Packages.pytest-postgresql
  • python311Packages.pytest-postgresql.dist
  • python311Packages.python-mapnik
  • python311Packages.python-mapnik.dist
  • python311Packages.qcodes
  • python311Packages.qcodes-contrib-drivers
  • python311Packages.qcodes-contrib-drivers.dist
  • python311Packages.qcodes.dist
  • python311Packages.rasterio
  • python311Packages.rasterio.dist
  • python311Packages.shapely
  • python311Packages.shapely.dist
  • python311Packages.spectral-cube
  • python311Packages.spectral-cube.dist
  • python311Packages.uranium
  • python311Packages.wktutils
  • python311Packages.wktutils.dist
  • python311Packages.wrf-python
  • python311Packages.wrf-python.dist
  • pytrainer
  • pytrainer.dist
  • qgis
  • qgis-ltr
  • qmapshack
  • saga
  • spatialite_gui
  • spatialite_tools
  • sumo
  • tests.pkg-config.defaultPkgConfigPackages.geos
  • udig
  • valhalla
  • vpv

@willcohen
Copy link
Contributor

willcohen commented Dec 6, 2023 •
edited
Loading

I would suggest adding a new derivation for GEOS 3.11 (much like 3.9 for other legacy uses: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/libraries/geos/3.9.nix) and shifting pygeos to use that as a dependency (and perhaps note either in top-level or the 3.11 derivation that this is being maintained solely for pygeos). That way pygeos can keep living for users who can't migrate to shapely, but we don't have to hold up the version bump for everyone else.

I called that 3.9 version geos39 in all-packages, so I suppose this could be geos311.

willcohen
willcohen requested changes Dec 6, 2023
View reviewed changes
@imincik
Copy link
Contributor Author

imincik commented Dec 6, 2023 •
edited
Loading

  1. pygeosis deprecated
  2. The offending tests are just skipped with skipif and GEOS version condition

Feedback appreciated...

@nialov , thank you very much for this investigation. As I said in previous comment, we can keep GEOS 3.11 for some time. After that we deprecate pygeos.

@imincik
Copy link
Contributor Author

imincik commented Dec 6, 2023 •
edited
Loading

Error in psycopg is related to flaky tests, they sometimes fail, sometimes not. Fix in progress: psycopg/psycopg#693 & #271926

Great thanks for psycopg fix. I'll add it to our psycopg package once it is ready.

@imincik
geos: keep version 3.11 of package
1b2bab0 
Keep old version of package due to requirements
of following packages:

* kikit
* pygeos
@imincik
python3Packages.pygeos: use GEOS 3.11
8a9d435
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Dec 6, 2023
@imincik
python3Packages.shapely: keep version 1.8
18437fb 
Keep old version of package due to requirements
of following packages:

* kikit
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Dec 6, 2023
@ofborg ofborg bot requested a review from willcohen December 6, 2023 16:04
@imincik
Copy link
Contributor Author

imincik commented Dec 6, 2023

@ofborg build kikit python3Packages.pygeos

@imincik imincik requested review from jfly and matusf December 6, 2023 16:08
@nialov
Copy link
Contributor

nialov commented Dec 6, 2023

Thanks for the responses, keeping pygeos alive for now sounds good to me 👍

@nialov
Copy link
Contributor

nialov commented Dec 6, 2023

psycopg fix is merged to master.

@imincik
kikit: use shapely 1.8
9a07607 
Use maintained version of shapely 1.8 instead of locally packaged
version.
@imincik
Copy link
Contributor Author

imincik commented Dec 6, 2023

@ofborg build kikit python3Packages.pygeos

@imincik
Copy link
Contributor Author

imincik commented Dec 7, 2023 •
edited
Loading 

nixpkgs-review pr --build-args "--max-jobs 2 --cores 8"  --skip-package-regex '.*rlax.*' --skip-package-regex '.*bsuite.*' --skip-package-regex '.*opensfm.*' --skip-package-regex '.*plotine.*'     --post-result 268130

Result of nixpkgs-review pr 268130 run on x86_64-linux 1

5 packages marked as broken and skipped:
  • python310Packages.worldengine
  • python310Packages.worldengine.dist
  • python311Packages.worldengine
  • python311Packages.worldengine.dist
  • t-rex
8 packages failed to build:
  • python310Packages.plotnine
  • python310Packages.plotnine.dist
  • python311Packages.plotnine
  • python311Packages.plotnine.dist
  • python311Packages.qcodes
  • python311Packages.qcodes-contrib-drivers
  • python311Packages.qcodes-contrib-drivers.dist
  • python311Packages.qcodes.dist
215 packages built:
  • apacheHttpdPackages.mod_tile
  • cloudcompare
  • cura
  • easyocr (python311Packages.easyocr)
  • easyocr.dist (python311Packages.easyocr.dist)
  • entwine
  • gdal (python311Packages.gdal)
  • gdalMinimal
  • geos
  • geos311
  • gmt
  • gplates
  • grass
  • kicadAddons.kikit
  • kicadAddons.kikit-library
  • kikit
  • kikit.dist
  • librasterlite2
  • librttopo
  • librttopo.dev
  • libspatialite
  • libspatialite.dev
  • mapcache
  • mapnik
  • mapproxy
  • mapproxy.dist
  • mapserver
  • merkaartor
  • moonraker
  • mysql-workbench
  • octavePackages.mapping
  • openorienteering-mapper
  • osm2pgsql
  • osmscout-server
  • paraview
  • pdal
  • perl536Packages.Tirex
  • perl536Packages.Tirex.devdoc
  • perl538Packages.Tirex
  • perl538Packages.Tirex.devdoc
  • pgadmin4
  • pgadmin4-desktopmode
  • pgadmin4-desktopmode.dist
  • pgadmin4.dist
  • pgcli (python311Packages.pgcli)
  • pgcli.dist (python311Packages.pgcli.dist)
  • postgresql12JitPackages.postgis
  • postgresql12JitPackages.postgis.doc
  • postgresql12Packages.postgis
  • postgresql12Packages.postgis.doc
  • postgresql13JitPackages.postgis
  • postgresql13JitPackages.postgis.doc
  • postgresql13Packages.postgis
  • postgresql13Packages.postgis.doc
  • postgresql14JitPackages.postgis
  • postgresql14JitPackages.postgis.doc
  • postgresql14Packages.postgis
  • postgresql14Packages.postgis.doc
  • postgresqlJitPackages.postgis (postgresql15JitPackages.postgis)
  • postgresqlJitPackages.postgis.doc (postgresql15JitPackages.postgis.doc)
  • postgresql15Packages.postgis
  • postgresql15Packages.postgis.doc
  • postgresql16JitPackages.postgis
  • postgresql16JitPackages.postgis.doc
  • postgresql16Packages.postgis
  • postgresql16Packages.postgis.doc
  • python310Packages.aplpy
  • python310Packages.aplpy.dist
  • python310Packages.asf-search
  • python310Packages.asf-search.dist
  • python310Packages.basemap
  • python310Packages.basemap.dist
  • python310Packages.cartopy
  • python310Packages.cartopy.dist
  • python310Packages.cf-xarray
  • python310Packages.cf-xarray.dist
  • python310Packages.django-bootstrap4
  • python310Packages.django-bootstrap4.dist
  • python310Packages.easyocr
  • python310Packages.easyocr.dist
  • python310Packages.fiona
  • python310Packages.fiona.dist
  • python310Packages.flask-admin
  • python310Packages.flask-admin.dist
  • python310Packages.folium
  • python310Packages.folium.dist
  • python310Packages.gdal
  • python310Packages.geoalchemy2
  • python310Packages.geoalchemy2.dist
  • python310Packages.geopandas
  • python310Packages.geopandas.dist
  • python310Packages.glueviz
  • python310Packages.glueviz.dist
  • python310Packages.labelbox
  • python310Packages.labelbox.dist
  • python310Packages.osmnx
  • python310Packages.osmnx.dist
  • python310Packages.owslib
  • python310Packages.owslib.dist
  • python310Packages.pgcli
  • python310Packages.pgcli.dist
  • python310Packages.pgspecial
  • python310Packages.pgspecial.dist
  • python310Packages.pgvector
  • python310Packages.pgvector.dist
  • python310Packages.preprocess-cancellation
  • python310Packages.preprocess-cancellation.dist
  • python310Packages.psycopg
  • python310Packages.psycopg.dist
  • python310Packages.psycopg.doc
  • python310Packages.pvextractor
  • python310Packages.pvextractor.dist
  • python310Packages.pygmt
  • python310Packages.pygmt.dist
  • python310Packages.pyosmium
  • python310Packages.pyosmium.dist
  • python310Packages.pyproj
  • python310Packages.pyproj.dist
  • python310Packages.pytest-postgresql
  • python310Packages.pytest-postgresql.dist
  • python310Packages.python-mapnik
  • python310Packages.python-mapnik.dist
  • python310Packages.qcodes
  • python310Packages.qcodes-contrib-drivers
  • python310Packages.qcodes-contrib-drivers.dist
  • python310Packages.qcodes.dist
  • python310Packages.rasterio
  • python310Packages.rasterio.dist
  • python310Packages.shapely
  • python310Packages.shapely.dist
  • python310Packages.shapely18
  • python310Packages.shapely18.dist
  • python310Packages.spectral-cube
  • python310Packages.spectral-cube.dist
  • python310Packages.uranium
  • python310Packages.wktutils
  • python310Packages.wktutils.dist
  • python310Packages.wrf-python
  • python310Packages.wrf-python.dist
  • python311Packages.aplpy
  • python311Packages.aplpy.dist
  • python311Packages.asf-search
  • python311Packages.asf-search.dist
  • python311Packages.basemap
  • python311Packages.basemap.dist
  • python311Packages.cartopy
  • python311Packages.cartopy.dist
  • python311Packages.cf-xarray
  • python311Packages.cf-xarray.dist
  • python311Packages.django-bootstrap4
  • python311Packages.django-bootstrap4.dist
  • python311Packages.fiona
  • python311Packages.fiona.dist
  • python311Packages.flask-admin
  • python311Packages.flask-admin.dist
  • python311Packages.folium
  • python311Packages.folium.dist
  • python311Packages.geoalchemy2
  • python311Packages.geoalchemy2.dist
  • python311Packages.geopandas
  • python311Packages.geopandas.dist
  • python311Packages.glueviz
  • python311Packages.glueviz.dist
  • python311Packages.labelbox
  • python311Packages.labelbox.dist
  • python311Packages.osmnx
  • python311Packages.osmnx.dist
  • python311Packages.owslib
  • python311Packages.owslib.dist
  • python311Packages.pgspecial
  • python311Packages.pgspecial.dist
  • python311Packages.pgvector
  • python311Packages.pgvector.dist
  • python311Packages.preprocess-cancellation
  • python311Packages.preprocess-cancellation.dist
  • python311Packages.psycopg
  • python311Packages.psycopg.dist
  • python311Packages.psycopg.doc
  • python311Packages.pvextractor
  • python311Packages.pvextractor.dist
  • python311Packages.pygmt
  • python311Packages.pygmt.dist
  • python311Packages.pyosmium
  • python311Packages.pyosmium.dist
  • python311Packages.pyproj
  • python311Packages.pyproj.dist
  • python311Packages.pytest-postgresql
  • python311Packages.pytest-postgresql.dist
  • python311Packages.python-mapnik
  • python311Packages.python-mapnik.dist
  • python311Packages.rasterio
  • python311Packages.rasterio.dist
  • python311Packages.shapely
  • python311Packages.shapely.dist
  • python311Packages.shapely18
  • python311Packages.shapely18.dist
  • python311Packages.spectral-cube
  • python311Packages.spectral-cube.dist
  • python311Packages.uranium
  • python311Packages.wktutils
  • python311Packages.wktutils.dist
  • python311Packages.wrf-python
  • python311Packages.wrf-python.dist
  • pytrainer
  • pytrainer.dist
  • qgis
  • qgis-ltr
  • qmapshack
  • saga
  • spatialite_gui
  • spatialite_tools
  • sumo
  • udig
  • valhalla
  • vpv

@imincik
Copy link
Contributor Author

imincik commented Dec 7, 2023

@NixOS/geospatial , PR finally looks good now. Please review. Thanks.

@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Dec 7, 2023
@imincik
Copy link
Contributor Author

imincik commented Dec 7, 2023 •
edited
Loading 

nixpkgs-review pr --build-args "--max-jobs 2 --cores 8"  --skip-package-regex '.*rlax.*' --skip-package-regex '.*bsuite.*' --skip-package-regex '.*opensfm.*' --skip-package-regex '.*plotnine.*' --skip-package-regex '.*qcodes.*'    --post-result 268130

Result of nixpkgs-review pr 268130 run on x86_64-linux 1

5 packages marked as broken and skipped:
  • python310Packages.worldengine
  • python310Packages.worldengine.dist
  • python311Packages.worldengine
  • python311Packages.worldengine.dist
  • t-rex
212 packages built:
  • apacheHttpdPackages.mod_tile
  • cloudcompare
  • cura
  • easyocr (python311Packages.easyocr)
  • easyocr.dist (python311Packages.easyocr.dist)
  • entwine
  • gdal (python311Packages.gdal)
  • gdalMinimal
  • geos
  • geos_3_11
  • geos_3_9
  • gmt
  • gplates
  • grass
  • kicadAddons.kikit
  • kicadAddons.kikit-library
  • kikit
  • kikit.dist
  • librasterlite2
  • librttopo
  • librttopo.dev
  • libspatialite
  • libspatialite.dev
  • mapcache
  • mapnik
  • mapproxy
  • mapproxy.dist
  • mapserver
  • merkaartor
  • moonraker
  • mysql-workbench
  • octavePackages.mapping
  • openorienteering-mapper
  • osm2pgsql
  • osmscout-server
  • paraview
  • pdal
  • perl536Packages.Tirex
  • perl536Packages.Tirex.devdoc
  • perl538Packages.Tirex
  • perl538Packages.Tirex.devdoc
  • pgadmin4
  • pgadmin4-desktopmode
  • pgadmin4-desktopmode.dist
  • pgadmin4.dist
  • pgcli (python311Packages.pgcli)
  • pgcli.dist (python311Packages.pgcli.dist)
  • postgresql12JitPackages.postgis
  • postgresql12JitPackages.postgis.doc
  • postgresql12Packages.postgis
  • postgresql12Packages.postgis.doc
  • postgresql13JitPackages.postgis
  • postgresql13JitPackages.postgis.doc
  • postgresql13Packages.postgis
  • postgresql13Packages.postgis.doc
  • postgresql14JitPackages.postgis
  • postgresql14JitPackages.postgis.doc
  • postgresql14Packages.postgis
  • postgresql14Packages.postgis.doc
  • postgresqlJitPackages.postgis (postgresql15JitPackages.postgis)
  • postgresqlJitPackages.postgis.doc (postgresql15JitPackages.postgis.doc)
  • postgresql15Packages.postgis
  • postgresql15Packages.postgis.doc
  • postgresql16JitPackages.postgis
  • postgresql16JitPackages.postgis.doc
  • postgresql16Packages.postgis
  • postgresql16Packages.postgis.doc
  • python310Packages.aplpy
  • python310Packages.aplpy.dist
  • python310Packages.asf-search
  • python310Packages.asf-search.dist
  • python310Packages.basemap
  • python310Packages.basemap.dist
  • python310Packages.cartopy
  • python310Packages.cartopy.dist
  • python310Packages.cf-xarray
  • python310Packages.cf-xarray.dist
  • python310Packages.django-bootstrap4
  • python310Packages.django-bootstrap4.dist
  • python310Packages.easyocr
  • python310Packages.easyocr.dist
  • python310Packages.fiona
  • python310Packages.fiona.dist
  • python310Packages.flask-admin
  • python310Packages.flask-admin.dist
  • python310Packages.folium
  • python310Packages.folium.dist
  • python310Packages.gdal
  • python310Packages.geoalchemy2
  • python310Packages.geoalchemy2.dist
  • python310Packages.geopandas
  • python310Packages.geopandas.dist
  • python310Packages.glueviz
  • python310Packages.glueviz.dist
  • python310Packages.labelbox
  • python310Packages.labelbox.dist
  • python310Packages.osmnx
  • python310Packages.osmnx.dist
  • python310Packages.owslib
  • python310Packages.owslib.dist
  • python310Packages.pgcli
  • python310Packages.pgcli.dist
  • python310Packages.pgspecial
  • python310Packages.pgspecial.dist
  • python310Packages.pgvector
  • python310Packages.pgvector.dist
  • python310Packages.preprocess-cancellation
  • python310Packages.preprocess-cancellation.dist
  • python310Packages.psycopg
  • python310Packages.psycopg.dist
  • python310Packages.psycopg.doc
  • python310Packages.pvextractor
  • python310Packages.pvextractor.dist
  • python310Packages.pygmt
  • python310Packages.pygmt.dist
  • python310Packages.pyosmium
  • python310Packages.pyosmium.dist
  • python310Packages.pyproj
  • python310Packages.pyproj.dist
  • python310Packages.pytest-postgresql
  • python310Packages.pytest-postgresql.dist
  • python310Packages.python-mapnik
  • python310Packages.python-mapnik.dist
  • python310Packages.rasterio
  • python310Packages.rasterio.dist
  • python310Packages.shapely
  • python310Packages.shapely.dist
  • python310Packages.shapely_1_8
  • python310Packages.shapely_1_8.dist
  • python310Packages.spectral-cube
  • python310Packages.spectral-cube.dist
  • python310Packages.uranium
  • python310Packages.wktutils
  • python310Packages.wktutils.dist
  • python310Packages.wrf-python
  • python310Packages.wrf-python.dist
  • python311Packages.aplpy
  • python311Packages.aplpy.dist
  • python311Packages.asf-search
  • python311Packages.asf-search.dist
  • python311Packages.basemap
  • python311Packages.basemap.dist
  • python311Packages.cartopy
  • python311Packages.cartopy.dist
  • python311Packages.cf-xarray
  • python311Packages.cf-xarray.dist
  • python311Packages.django-bootstrap4
  • python311Packages.django-bootstrap4.dist
  • python311Packages.fiona
  • python311Packages.fiona.dist
  • python311Packages.flask-admin
  • python311Packages.flask-admin.dist
  • python311Packages.folium
  • python311Packages.folium.dist
  • python311Packages.geoalchemy2
  • python311Packages.geoalchemy2.dist
  • python311Packages.geopandas
  • python311Packages.geopandas.dist
  • python311Packages.glueviz
  • python311Packages.glueviz.dist
  • python311Packages.labelbox
  • python311Packages.labelbox.dist
  • python311Packages.osmnx
  • python311Packages.osmnx.dist
  • python311Packages.owslib
  • python311Packages.owslib.dist
  • python311Packages.pgspecial
  • python311Packages.pgspecial.dist
  • python311Packages.pgvector
  • python311Packages.pgvector.dist
  • python311Packages.preprocess-cancellation
  • python311Packages.preprocess-cancellation.dist
  • python311Packages.psycopg
  • python311Packages.psycopg.dist
  • python311Packages.psycopg.doc
  • python311Packages.pvextractor
  • python311Packages.pvextractor.dist
  • python311Packages.pygmt
  • python311Packages.pygmt.dist
  • python311Packages.pyosmium
  • python311Packages.pyosmium.dist
  • python311Packages.pyproj
  • python311Packages.pyproj.dist
  • python311Packages.pytest-postgresql
  • python311Packages.pytest-postgresql.dist
  • python311Packages.python-mapnik
  • python311Packages.python-mapnik.dist
  • python311Packages.rasterio
  • python311Packages.rasterio.dist
  • python311Packages.shapely
  • python311Packages.shapely.dist
  • python311Packages.shapely_1_8
  • python311Packages.shapely_1_8.dist
  • python311Packages.spectral-cube
  • python311Packages.spectral-cube.dist
  • python311Packages.uranium
  • python311Packages.wktutils
  • python311Packages.wktutils.dist
  • python311Packages.wrf-python
  • python311Packages.wrf-python.dist
  • pytrainer
  • pytrainer.dist
  • qgis
  • qgis-ltr
  • qmapshack
  • saga
  • spatialite_gui
  • spatialite_tools
  • sumo
  • udig
  • valhalla
  • vpv

@imincik
Copy link
Contributor Author

imincik commented Dec 8, 2023

@willcohen , thanks for review. Anybody else interested in review or we can merge now ?

@imincik
Copy link
Contributor Author

imincik commented Dec 11, 2023

@sikmir , if you are OK with this PR, would you please merge ? Thank you.

@sikmir sikmir mentioned this pull request Dec 13, 2023
Merged
12 tasks
@zimbatm zimbatm merged commit 5e18fcf into NixOS:master Dec 14, 2023
imincik added a commit to imincik/geospatial-nix that referenced this pull request Dec 15, 2023
@imincik
pkgs(geos): 3.11.2 -> 3.12.1
5cf07c1 
Nixpgs PR:
NixOS/nixpkgs#268130
@nixos-discourse
Copy link

nixos-discourse commented Dec 18, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/week-in-geospatial-team-11-17-dec-2023/37035/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimbatm zimbatm zimbatm approved these changes

@willcohen willcohen willcohen approved these changes

@nh2 nh2 Awaiting requested review from nh2

@sikmir sikmir Awaiting requested review from sikmir

@das-g das-g Awaiting requested review from das-g

@nialov nialov Awaiting requested review from nialov

@matusf matusf Awaiting requested review from matusf

@jfly jfly Awaiting requested review from jfly

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@imincik @nialov @willcohen @nixos-discourse @zimbatm