nixos: replace activationScripts 2/x#267983
Merged
nikstur merged 13 commits intoNixOS:masterfrom Dec 29, 2023
Merged
Conversation
github-actions
bot
added
6.topic: nixos
nikstur
force-pushed
the
replace-simple-activation-2
branch
from
135942e to
53a7e4d
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
|
I misclicked on a review. I'm going to actually review this... (Side note: I hate that I can't review individual commits.) |
lovesegfault
approved these changes
Nov 28, 2023
philiptaron
approved these changes
Nov 29, 2023
Contributor
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
Some curiosities, but this looks good to me.
nikstur
force-pushed
the
replace-simple-activation-2
branch
2 times, most recently
from
266bb93 to
7de0090
Compare
Member
SuperSandro2000
left a comment
SuperSandro2000
left a comment
There was a problem hiding this comment.
would have love to give some deeper feedback but the changes are a bit tricky for me :/
Replace with a dedicated system servie ordered before the other VMWare services.
Replace with a dedicated systemd service.
Replace with a separate systemd service ordered before sysinit.target
Replace with separate service because it cannot be moved into the preStart of the yggdrasil service.
Replace with a seprate systemd service
Replaced with a dedicated systemd service.
nikstur
force-pushed
the
replace-simple-activation-2
branch
from
7de0090 to
0ebd39b
Compare
Contributor
Author
|
@ofborg test yggdrasil nextcloud.basic26 wrappers borgbackup incron |
Contributor
Author
|
I added shutdown.target dependencies to the sysinit services to be aligned with #271326 and converted the nextcloud service to tmpfiles. |
philiptaron
reviewed
Dec 29, 2023
Contributor
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
So glad to see this land.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Replace some more relatively easy to replace activationScripts. This is the second PR of the series started here: #263203
It's part of the broader "Perlless Activation" endeavour: #267982
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)