Skip to content

systemd: 254.3 -> 254.6#267802

Merged
RaitoBezarius merged 1 commit intoNixOS:stagingfrom
lilyinstarlight:upd/systemd-254.6
Nov 21, 2023
Merged

systemd: 254.3 -> 254.6#267802
RaitoBezarius merged 1 commit intoNixOS:stagingfrom
lilyinstarlight:upd/systemd-254.6

Conversation

@lilyinstarlight
Copy link
Member

@lilyinstarlight lilyinstarlight commented Nov 16, 2023

Description of changes

I ran a few NixOS tests successfully and confirmed pkgsMusl.systemd and pkgsCross.aarch64-multiplatform.systemd still built when cherry-picked on top of master

There's some bug fixes @JulienMalka wanted (for encrypted initrd secrets). @RaitoBezarius said in #systemd:nixos.org to make this draft and target this for backport to staging-23.11 when we have that

Will make a merge conflict for #265951 (cc @nikstur)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
    • x86_64-linux -> aarch64-linux (cross)
    • x86_64-linux-musl
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. label Nov 16, 2023
@lilyinstarlight lilyinstarlight changed the title systemd: 254.4 -> 254.6 systemd: 254.3 -> 254.6 Nov 16, 2023
@ofborg ofborg bot requested review from flokli and kloenk November 16, 2023 06:11
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Nov 16, 2023
@RaitoBezarius RaitoBezarius marked this pull request as ready for review November 19, 2023 16:09
@RaitoBezarius RaitoBezarius requested a review from a team as a code owner November 19, 2023 16:09
@RaitoBezarius
Copy link
Member

Result of nixpkgs-review pr 267802 run on x86_64-linux 1

3 packages built:
  • systemd
  • systemd.dev (systemd.dev.dev ,systemd.dev.man)
  • systemd.man (systemd.man.dev ,systemd.man.man)

2 similar comments
@RaitoBezarius
Copy link
Member

Result of nixpkgs-review pr 267802 run on x86_64-linux 1

3 packages built:
  • systemd
  • systemd.dev (systemd.dev.dev ,systemd.dev.man)
  • systemd.man (systemd.man.dev ,systemd.man.man)

@RaitoBezarius
Copy link
Member

Result of nixpkgs-review pr 267802 run on x86_64-linux 1

3 packages built:
  • systemd
  • systemd.dev (systemd.dev.dev ,systemd.dev.man)
  • systemd.man (systemd.man.dev ,systemd.man.man)

Copy link
Contributor

@misuzu misuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No isses when building for armv7l-linux (cross, native)

@RaitoBezarius RaitoBezarius merged commit 3d733b6 into NixOS:staging Nov 21, 2023
@RaitoBezarius
Copy link
Member

I didn't finish fully the testing but this is a minor version, no reason to continue to hold up on it.

@github-actions
Copy link
Contributor

Successfully created backport PR for staging-23.11:

@lilyinstarlight lilyinstarlight deleted the upd/systemd-254.6 branch November 21, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants