Skip to content

gst-plugins-good: add openssl dependency#267733

Merged
lilyinstarlight merged 1 commit intoNixOS:stagingfrom
max-privatevoid:gst-plugins-good-openssl
Nov 24, 2023
Merged

gst-plugins-good: add openssl dependency#267733
lilyinstarlight merged 1 commit intoNixOS:stagingfrom
max-privatevoid:gst-plugins-good-openssl

Conversation

@max-privatevoid
Copy link
Contributor

@max-privatevoid max-privatevoid commented Nov 15, 2023 •
edited
Loading

Description of changes

This adds OpenSSL as a dependency to gst-plugins-good, which enables hls-crypto AKA streaming things over HTTPS.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Nov 15, 2023
Gerg-L
Gerg-L approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@Gerg-L Gerg-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 15, 2023
Henry-Hiles
Henry-Hiles approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@Henry-Hiles Henry-Hiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Henry-Hiles Henry-Hiles added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 16, 2023
@Henry-Hiles
Copy link
Contributor

Henry-Hiles commented Nov 16, 2023

Also, would this mean that libsoup would no longer be a needed dependency for monophony?

@max-privatevoid
Copy link
Contributor Author

max-privatevoid commented Nov 22, 2023

Appears to be that way. Weird that the presence of libsoup didn't make it work before for me.

@Henry-Hiles
Copy link
Contributor

Henry-Hiles commented Nov 22, 2023

Odd, it works for me. If it doesn't, try clearing gstreamer cache.

@max-privatevoid
Copy link
Contributor Author

max-privatevoid commented Nov 23, 2023

...of course that works. WHY IS THERE A CACHE FOR THIS??? Thanks for pointing it out. I'll change the PR description. Maybe some other application can benefit from having https support in the regular gstreamer plugins?

@Henry-Hiles
Copy link
Contributor

Henry-Hiles commented Nov 23, 2023

...of course that works. WHY IS THERE A CACHE FOR THIS??? Thanks for pointing it out. I'll change the PR description. Maybe some other application can benefit from having https support in the regular gstreamer plugins?

Well I could remove libsoup as a dep which would he nice.

lilyinstarlight
lilyinstarlight approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, thank you!

Also seems to not increase closure size, which is good

@lilyinstarlight lilyinstarlight merged commit ba1294c into NixOS:staging Nov 24, 2023
@github-actions github-actions bot mentioned this pull request Nov 24, 2023
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2023

Successfully created backport PR for staging-23.11:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2023

Git push to origin failed for staging-23.11 with exitcode 1

@Henry-Hiles Henry-Hiles mentioned this pull request Dec 4, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

3 more reviewers

@lilyinstarlight lilyinstarlight lilyinstarlight approved these changes

@Henry-Hiles Henry-Hiles Henry-Hiles approved these changes

@Gerg-L Gerg-L Gerg-L approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@max-privatevoid @Henry-Hiles @lilyinstarlight @Gerg-L @delroth