Skip to content

libglvnd: enable 64-bit file APIs#267505

Merged
Artturin merged 1 commit intoNixOS:stagingfrom
trofi:libglvnd-64-bit-file-api
Nov 15, 2023
Merged

libglvnd: enable 64-bit file APIs#267505
Artturin merged 1 commit intoNixOS:stagingfrom
trofi:libglvnd-64-bit-file-api

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Nov 14, 2023

Without the change 32-bit programs like wine or mesa-demos fail to start on filesystems with 64-bit inodes.

Pull the patch pending upstream inclusion:
https://gitlab.freedesktop.org/glvnd/libglvnd/-/merge_requests/288

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Without the change 32-bit programs like `wine` or `mesa-demos` fail to
start on filesystems with 64-bit inodes.

Pull the patch pending upstream inclusion:
https://gitlab.freedesktop.org/glvnd/libglvnd/-/merge_requests/288
@ofborg ofborg bot requested a review from primeos November 14, 2023 20:37
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Nov 14, 2023
@Artturin Artturin merged commit c76c0e0 into NixOS:staging Nov 15, 2023
@trofi trofi deleted the libglvnd-64-bit-file-api branch November 15, 2023 07:27
@vcunat
Copy link
Member

vcunat commented Nov 15, 2023

Oh. I believe we should stage this for 23.11 as well, eventually. (There's no suitable target branch right now.)

@trofi
Copy link
Contributor Author

trofi commented Nov 19, 2023

I noticed some use the backport staging-23.11 label for that. Would it apply here as well?

@github-actions
Copy link
Contributor

Successfully created backport PR for staging-23.11:

@vcunat
Copy link
Member

vcunat commented Nov 19, 2023

Yes, that's it. It was only added today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants