Merged
Conversation
13 tasks
andrevmatos
approved these changes
Nov 14, 2023
Member
andrevmatos
left a comment
andrevmatos
left a comment
There was a problem hiding this comment.
nixos-unstable-small is currently broken by this (plasma5Packages doesn't contain several required members, like plasma5), and the fix works
delroth
added
the
12.approvals: 1
Member
Author
These changes shouldn't affect non-cross
|
ofborg
bot
added
10.rebuild-darwin: 0
Member
|
Hmm, may be something weird on my flake setup then, or with some change on master but not yet on unstable-small (had to bump lock to apply this). Either way, it now works for me. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)