Skip to content

pam: 1.5.2 -> 1.5.3#267447

Merged
marsam merged 1 commit intoNixOS:stagingfrom
trofi:pam-update
Jan 6, 2024
Merged

pam: 1.5.2 -> 1.5.3#267447
marsam merged 1 commit intoNixOS:stagingfrom
trofi:pam-update

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Nov 14, 2023

Changes: https://github.com/linux-pam/linux-pam/releases/tag/v1.5.3

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Nov 14, 2023
@marsam
Copy link
Contributor

marsam commented Nov 24, 2023

@GrahamcOfBorg eval

@wegank wegank mentioned this pull request Nov 30, 2023
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I run a pamless system so I will let somebody else do the merge.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3086

@onemoresuza onemoresuza added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Dec 12, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1303

@trofi trofi closed this Dec 31, 2023
@trofi trofi deleted the pam-update branch December 31, 2023 17:38
@trofi trofi restored the pam-update branch December 31, 2023 20:26
@trofi trofi reopened this Dec 31, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1362

@marsam marsam merged commit b8c15e6 into NixOS:staging Jan 6, 2024
@trofi trofi deleted the pam-update branch January 6, 2024 14:03
@trofi
Copy link
Contributor Author

trofi commented Jan 15, 2024

1.5.3 introduced a regression in nixpkgs by disabling pam_lastlog by default. Proposed the fix as #281182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants