fileset.fileFilter: Don't run predicate unnecessarily#267381
Merged
infinisil merged 2 commits intoNixOS:masterfrom Nov 15, 2023
Merged
fileset.fileFilter: Don't run predicate unnecessarily#267381infinisil merged 2 commits intoNixOS:masterfrom
fileset.fileFilter: Don't run predicate unnecessarily#267381infinisil merged 2 commits intoNixOS:masterfrom
Conversation
Before:
nix-repl> fileset.trace (fileset.fileFilter (file: builtins.trace file.name false) ./default.nix)
trace: README.md
trace: benchmark.sh
trace: default.nix
trace: internal.nix
trace: mock-splitRoot.nix
trace: tests.sh
After:
nix-repl> fileset.trace (fileset.fileFilter (file: builtins.trace file.name false) ./default.nix)
trace: default.nix
ofborg
bot
added
10.rebuild-darwin: 0
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Before:
After:
Note that even if the filter returned true before, the files weren't added to the store, so this is just a performance and laziness improvement and arguably not a bug fix.
This work is sponsored by Antithesis ✨
Things done