libsForQt5: fix using `pkgsCross.aarch64-multiplatform.pkgsBuildTarge…#267323
Merged
Artturin merged 1 commit intoNixOS:masterfrom Nov 14, 2023
Merged
libsForQt5: fix using `pkgsCross.aarch64-multiplatform.pkgsBuildTarge…#267323Artturin merged 1 commit intoNixOS:masterfrom
Artturin merged 1 commit intoNixOS:masterfrom
Conversation
…t.targetPackages.libsForQt5.qtbase` explicitly without splicing interfering in, for example, `nativeBuildInputs`.
13 tasks
ofborg
bot
added
10.rebuild-darwin: 0
|
Ugh. This breaks splicing for me in context of #267311. I get Instead of |
Member
Author
|
the attributes have __spliced but they're one step too early in the sliding window (something lke that) Those both should be aarch64-linux with |
Artturin
commented
Nov 14, 2023
| # qt5 set should not be pre-spliced to prevent spliced packages being a part of an unspliced set | ||
| # 'pkgsCross.aarch64-multiplatform.pkgsBuildTarget.targetPackages.libsForQt5.qtbase' should not have a `__spliced` but if qt5 is pre-spliced then it will have one. | ||
| # pkgsBuildHost == pkgs | ||
| qt5 = pkgsBuildHost.qt5; |
Member
Author
There was a problem hiding this comment.
Used pkgsBuildHost here while i should have used pkgsHostTarget
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t.targetPackages.libsForQt5.qtbase` explicitly
without splicing interfering
in, for example,
nativeBuildInputs.Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)