Skip to content

goModule: allow passing in NIX_GIT_SSL_CAINFO#266643

Closed
timbertson wants to merge 1 commit intoNixOS:masterfrom
timbertson:gomodule-ssl-cainfo
Closed

goModule: allow passing in NIX_GIT_SSL_CAINFO#266643
timbertson wants to merge 1 commit intoNixOS:masterfrom
timbertson:gomodule-ssl-cainfo

Conversation

@timbertson
Copy link
Contributor

Description of changes

Go module fetcher: support (impure) NIX_GIT_SSL_CAINFO

This is the same idea / envvar as used in fetchgit, added in 6f53c06

The primary use case is when there's a http(s) proxy, the user may want to override the nix-provided CA certificates.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. label Nov 10, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 10, 2023
@timbertson
Copy link
Contributor Author

I think #271161 is a better way to solve this problem, then we can use the standard envvar instead of inventing a new one just for git fetching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant