Skip to content

sarif-fmt: init at 0.4.2#266570

Merged
Artturin merged 1 commit intoNixOS:masterfrom
getchoo-contrib:pkgs/sarif-fmt/init
Jun 10, 2024
Merged

sarif-fmt: init at 0.4.2#266570
Artturin merged 1 commit intoNixOS:masterfrom
getchoo-contrib:pkgs/sarif-fmt/init

Conversation

@getchoo
Copy link
Member

@getchoo getchoo commented Nov 10, 2023

Description of changes

sarif-fmt is a CLI tool to pretty print SARIF diagnostics. It is a part of the sarif-rs group of projects

related to #266558

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 10, 2023
@getchoo getchoo force-pushed the pkgs/sarif-fmt/init branch from 09a9f3e to 6d457b6 Compare November 10, 2023 07:58
@getchoo getchoo force-pushed the pkgs/sarif-fmt/init branch from 6d457b6 to f6b6243 Compare May 8, 2024 20:41
@Scrumplex
Copy link
Member

Result of nixpkgs-review pr 266570 run on x86_64-linux 1

1 package built:
  • sarif-fmt

@Scrumplex Scrumplex added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 9, 2024
@Artturin
Copy link
Member

The darwin build fails error[E0463]: can't find crate for profiler_builtins`

"--enable-profiler" # build libprofiler_builtins

asked in the nix rust matrix room about enabling profiling on darwin

@Scrumplex
Copy link
Member

Result of nixpkgs-review pr 266570 run on x86_64-linux 1

1 package built:
  • sarif-fmt

@Artturin
Copy link
Member

Artturin commented Jun 9, 2024

Test still fails, either skip it on darwin or mark broken on darwin.

@getchoo getchoo force-pushed the pkgs/sarif-fmt/init branch from fdb79e9 to 96b80aa Compare June 10, 2024 09:10
@Artturin Artturin force-pushed the pkgs/sarif-fmt/init branch from 96b80aa to 5e7cc9a Compare June 10, 2024 14:11
@Artturin
Copy link
Member

Remember to include the reason why it's disabled in the comment. Added it for you.

@Artturin Artturin merged commit 53b8469 into NixOS:master Jun 10, 2024
@getchoo getchoo deleted the pkgs/sarif-fmt/init branch June 10, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants