Skip to content

clippy-sarif: init at 0.4.2#266558

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
getchoo-contrib:pkgs/clippy-sarif/init
Jun 25, 2024
Merged

clippy-sarif: init at 0.4.2#266558
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
getchoo-contrib:pkgs/clippy-sarif/init

Conversation

@getchoo
Copy link
Member

@getchoo getchoo commented Nov 10, 2023 •
edited
Loading

Description of changes

clippy-sarif is a CLI tool to convert clippy diagnostics into SARIF. It is a part of the sarif-rs group of projects.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 10, 2023
This was referenced Nov 10, 2023
Merged
Merged
Merged
Merged
@getchoo getchoo force-pushed the pkgs/clippy-sarif/init branch from f50983f to ad6c179 Compare November 10, 2023 07:58
@Sigmanificient Sigmanificient added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 30, 2024
@uncenter
Copy link
Member

uncenter commented Apr 30, 2024

Result of nixpkgs-review pr 266558 run on aarch64-darwin 1

1 package built:
  • clippy-sarif

@getchoo getchoo force-pushed the pkgs/clippy-sarif/init branch from ad6c179 to bdfb5a4 Compare May 8, 2024 20:38
@getchoo
Copy link
Member Author

getchoo commented May 8, 2024

rebased on master and refactored a bit

@getchoo getchoo requested review from isabelroses and uncenter May 8, 2024 20:39
@isabelroses
Copy link
Member

isabelroses commented May 8, 2024 •
edited
Loading

Result of nixpkgs-review pr 266558 run on x86_64-linux 1

1 package failed to build:
  • clippy-sarif

the error I got is bad archive: input doesn't look like a Nix archive

@uncenter
Copy link
Member

uncenter commented May 8, 2024

Result of nixpkgs-review pr 266558 run on aarch64-darwin 1

1 package built:
  • clippy-sarif

@getchoo
Copy link
Member Author

getchoo commented May 9, 2024

@isabelroses could you try to run this again? i'm not really sure how this could happen unless there was maybe a corrupted download for the archive. this doesn't happen for me (on the same architecture) or uncenter, so i'm a bit curious here

Result of nixpkgs-review pr 266558 run on x86_64-linux 1

1 package built:
  • clippy-sarif

@isabelroses
Copy link
Member

isabelroses commented May 9, 2024

@isabelroses could you try to run this again? i'm not really sure how this could happen unless there was maybe a corrupted download for the archive. this doesn't happen for me (on the same architecture) or uncenter, so i'm a bit curious here

Result of nixpkgs-review pr 266558 run on x86_64-linux 1

1 package built:

Yeah I figured the same, just ran it on a different system to be 100% sure. it's working now.

@getchoo getchoo added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels May 9, 2024
@nixos-discourse
Copy link

nixos-discourse commented May 9, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1623

@Scrumplex
Copy link
Member

Scrumplex commented May 9, 2024

Result of nixpkgs-review pr 266558 run on x86_64-linux 1

1 package built:
  • clippy-sarif

@Scrumplex Scrumplex added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels May 9, 2024
SuperSandro2000
SuperSandro2000 reviewed Jun 2, 2024
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Jun 2, 2024
View reviewed changes
@getchoo getchoo force-pushed the pkgs/clippy-sarif/init branch from bdfb5a4 to 16f7045 Compare June 4, 2024 10:39
@getchoo getchoo requested a review from SuperSandro2000 June 4, 2024 10:39
@SuperSandro2000 SuperSandro2000 merged commit 943264e into NixOS:master Jun 25, 2024
@getchoo getchoo deleted the pkgs/clippy-sarif/init branch June 25, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Scrumplex Scrumplex Scrumplex approved these changes

@isabelroses isabelroses isabelroses approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

+1 more reviewer

@uncenter uncenter uncenter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@getchoo @uncenter @isabelroses @nixos-discourse @Scrumplex @SuperSandro2000 @Sigmanificient