Closed
Conversation
bd8adaf to
ab8e5fc
Compare
ab8e5fc to
6f87b0b
Compare
6f87b0b to
38fb7b6
Compare
Overriding chapter of the Nixpkgs manual38fb7b6 to
1a0bf55
Compare
Contributor
Author
|
@ofborg build tests.overriding |
Contributor
Author
|
Inspecting deeper into the
|
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR defines a function
lib.applyToOverridablethat make sure that an overridable (an attribute set one can override) behaves when updating its attributes directly (i.e. not by overriding).Without it, the updating will be lost once the overridable is overridden. For example,
((lib.extendDerivation true { ans = 42; } pkgs.hello).override { }).ansthrowserror: attribute 'ans' missing. This is relevant when applyingextendDerivationto a package produced bystdenv.mkDerivation.Packages produced by many language-specific build helpers suffers from such
overrideAttrsmisbehave. For example,pkgs.python3Packages.six.updateScriptevaluates successfully, but(pkgs.python311Packages.six.overrideAttrs { }).updateScriptthrowserror: attribute 'updateScript' missing. I'm not planning to fix them here, as they can be improved throughlib.extendMkDerivationModifiedin the future, which internally callslib.applyToOverridable. It sounds awkward to change them twice.This is split from #234651
This depends on #265710 for
lib.mirrorFunctionArgs.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)