lib.mirrorFunctionArgs: init#265710
Merged
infinisil merged 3 commits intoNixOS:masterfrom Nov 14, 2023
Merged
Conversation
ShamrockLee
requested review from
FRidh,
edolstra and
infinisil
as code owners
github-actions
bot
added
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 0
infinisil
reviewed
Nov 6, 2023
lib/trivial.nix
Outdated
Member
There was a problem hiding this comment.
Side note: This doesn't render in nixdoc right now, but I think we can keep it anyways
Contributor
Author
There was a problem hiding this comment.
I noticed that, too. It would be fine as long as the function description doesn't depend on the argument name used here.
Nevertheless, I do hope that the second one could get rendered in the future.
infinisil
requested changes
Nov 6, 2023
Co-authored-by: Silvan Mosberger <[email protected]>
Rename temporary variable copyArgs -> mirrorArgs. Use lib.mirrorFunctionArgs to define `mirrorArgs`. Apply mirrorArgs also to the returned function.
ShamrockLee
force-pushed
the
lib-copy-function-args
branch
from
f232c50 to
b3e2c15
Compare
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Add
lib.mirrorFunctionArgs f gas an intuitive shorthand oflib.setFunctionArgs g (lib.functionArgs f), with optimization that caches thelib.functionArgs fresult when partially applied.Use it in the definition of
lib.makeOverridableandmakeOverridablePythonPackage.The changes are split from #234651 to ease the review workload up with smaller PRs.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)